Closed Bug 960704 Opened 7 years ago Closed 7 years ago
Mirror to 3 .21
This update adds ES6 support and fixes some bugs we encountered.
Attachment #8361347 - Flags: review?(mihai.sucan)
Comment on attachment 8361347 [details] [diff] [review] WIP 1 Review of attachment 8361347 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. ::: browser/devtools/sourceeditor/codemirror/README @@ +25,5 @@ > + co-exist with Mozilla's testing infrastructure. > + * In cm_comment_test.js comment out fallbackToBlock and fallbackToLine > + tests. > + * The search addon (search.js) was slightly modified to make search > + UI localizable. How can we see what was changed? Do you have some patch files? If someone wants to update CM we should see what is patched in the current version. ::: browser/devtools/sourceeditor/codemirror/activeline.js @@ -1,4 @@ > -/* vim:set ts=2 sw=2 sts=2 et tw=80: > - * This Source Code Form is subject to the terms of the Mozilla Public > - * License, v. 2.0. If a copy of the MPL was not distributed with this > - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ Any reason why MPL license boilerplate was removed here?
Attachment #8361347 - Flags: review?(mihai.sucan) → review+
> How can we see what was changed? Do you have some patch files? Good point, maybe add exact steps to the README? I personally just do a diff of our version against CodeMirror's. > Any reason why MPL license boilerplate was removed here? It was incorrectly there since activeline.js is taken from the CodeMirror distribution.
https://hg.mozilla.org/integration/fx-team/rev/be8955ab1b41 Once it is merged to m-c and this bug is marked as RESOLVED FIXED, I will go over all blocked bugs, verify that they are fixed and close them as well.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.