960705 - [clock][l10n] "Close" button should say "Stop" instead

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Théo Chevalier]

On alarm ringing screen, the user have to choose between "Close" and "Snooze".

The close button should say "Stop", because you stop the alarm, you don't close it :)

Of course, the entity name should be updated.

Comment 1

[Marcus Cavanaugh [:mcav]]

Thoughts on this, Juwei?

Comment 2

[Théo Chevalier]

(In reply to Théo Chevalier [:tchevalier] from comment #0)
> Of course, the entity name should be updated.
Replying to myself, this is wrong, we already have a "Stop" entity.


Note that the same may apply to the Timer "Close" button, but I let you decide whereas this bug is valid or not.

Comment 3

[Juwei Huang[:juwei]]

Indeed, it should be a "Stop" instead.
How about "OK"? Is it sounds more positive than "Stop"?

Comment 4

[:gerard-majax]

(In reply to Juwei Huang from comment #3)
> Indeed, it should be a "Stop" instead.
> How about "OK"? Is it sounds more positive than "Stop"?

But it still makes no clear sense to the user.

Comment 5

[Gnaneswar]

How about "dismiss"?

Comment 6

[Marcus Cavanaugh [:mcav]]

iOS uses "Stop" if the phone is locked; if the phone is in use, it pops up a gross dialog box that just says "Timer Done" with an "OK" button.

The key distinction is, does the user know that the alarm is actually terminated, rather than just dismissed? With "Close" and "Dismiss", it's less clear if the alarm is actually terminated or if you're just hiding it.

I think that both "OK" and "Stop" are good terms; "OK" is an acknowledgement that you received the message (the alarm) and don't need to see it again. "Stop" is equally informative, IMO.

Comment 7

[Juwei Huang[:juwei]]

Let's go for "Stop" as Théo recommend.

Comment 8

[Gnaneswar]

I am working on to create a patch with "Stop"

Comment 9

[Gnaneswar]

Attachment: Pointer to Github PR

Marcus,

Let me know your comments if any.

Comment 10

[Théo Chevalier]

Comment on attachment 8374769 [details] [review]
Pointer to Github PR

Thanks for the patch Gnaneswar! Looks good from an l10n standpoint.

Comment 11

[Marcus Cavanaugh [:mcav]]

Looks great, thanks! Landed in 8a50fe986972e5f6a9c4410c556e45144c4306f8.

Comment 12

[Edward Chen[:edchen]]

[Verified info]
Gaia      6e71ab4da1b08586ea0c758edb7aa199ee34cd2f
Gecko     https://hg.mozilla.org/mozilla-central/rev/bb030d47c946
BuildID   20140219160202
Version   30.0a1

[Testing result]
PASS
The wording is changed and no other side effects. I mark it to "VERIFIED"