Closed Bug 960734 Opened 9 years ago Closed 9 years ago

Remove inline script / style in browser/devtools/layoutview/view.xhtml

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: bgrins, Assigned: k)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mentor=bgrins][lang=html][good first bug][lang=js][qa-])

Attachments

(1 file, 1 obsolete file)

Let's move any inline JavaScript, styles, and event handlers out of this file:  https://mxr.mozilla.org/mozilla-central/source/browser/devtools/layoutview/view.xhtml
Attached patch bug-960737.patch (obsolete) — Splinter Review
moved the inline script to view.js
Attachment #8361599 - Flags: review?(bgrinstead)
Hi Kay, thanks sending the patch over!  It looks good to me, I've also pushed it to our test server: https://tbpl.mozilla.org/?tree=Try&rev=a367041ec9e7
Assignee: nobody → k
Status: NEW → ASSIGNED
Comment on attachment 8361599 [details] [diff] [review]
bug-960737.patch

Review of attachment 8361599 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Can you edit the commit message to add ;r=bgrins at the end and resubmit the patch?
Attachment #8361599 - Flags: review?(bgrinstead)
Okay
Attachment #8361685 - Flags: review?(bgrinstead)
Comment on attachment 8361685 [details] [diff] [review]
bug-960737_1.patch

Review of attachment 8361685 [details] [diff] [review]:
-----------------------------------------------------------------

Let's wait until the try push is green before marking checkin-needed.
Attachment #8361685 - Flags: review?(bgrinstead) → review+
Attachment #8361599 - Attachment is obsolete: true
This looks good with the latest try push: https://tbpl.mozilla.org/?tree=Try&rev=88233b3b3a1d.  Kay, this is ready to checkin - you can add 'checkin-needed' to the "Keywords" field at the top of the bug to get it landed :)
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8a2d0c44af61
Keywords: checkin-needed
Whiteboard: [mentor=bgrins][lang=html][good first bug][lang=js] → [mentor=bgrins][lang=html][good first bug][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8a2d0c44af61
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=bgrins][lang=html][good first bug][lang=js][fixed-in-fx-team] → [mentor=bgrins][lang=html][good first bug][lang=js]
Target Milestone: --- → Firefox 29
Whiteboard: [mentor=bgrins][lang=html][good first bug][lang=js] → [mentor=bgrins][lang=html][good first bug][lang=js][qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.