Queries involving comment tags crash

RESOLVED FIXED in Bugzilla 5.0

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: LpSolit, Assigned: dkl)

Tracking

4.5.1
Bugzilla 5.0
Dependency tree / graph
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
This query makes Bugzilla to crash:

  https://bugzilla.mozilla.org/buglist.cgi?f1=comment_tag&o1=equals&v1=foo

"DBD::mysql::db selectcol_arrayref failed: Unknown column 'bugs.comment_tag' in 'where clause'"

The same error is returned upstream. The reason is that comment tags are stored in a separate DB table, but Bugzilla/Search.pm hasn't been updated to join this table when involving comment tags in queries.
(Assignee)

Comment 1

5 years ago
Created attachment 8361343 [details] [diff] [review]
960748_1.patch
Assignee: query-and-buglist → dkl
Status: NEW → ASSIGNED
Attachment #8361343 - Flags: review?(glob)
(Assignee)

Comment 2

5 years ago
Comment on attachment 8361343 [details] [diff] [review]
960748_1.patch

Revising patch to consider private comments :(
Attachment #8361343 - Flags: review?(glob)
(Assignee)

Comment 3

5 years ago
Created attachment 8361356 [details] [diff] [review]
960748_2.patch
Attachment #8361343 - Attachment is obsolete: true
Attachment #8361356 - Flags: review?(glob)
Comment on attachment 8361356 [details] [diff] [review]
960748_2.patch

r=glob, nice
Attachment #8361356 - Flags: review?(glob) → review+
Flags: approval+
(Assignee)

Comment 5

5 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/Search.pm
Committed revision 8870.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 960883
You need to log in before you can comment on or make changes to this bug.