960769 - [build] webapp-zip.js should not include building block .html files

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[James Burke [:jrburke]]

build/webapp-zip.js avoids copying any top level .html files in the copyBuildingBlock() function, but it looks like there are nested .html files now in shared/style and shared/style_unstable subcomponents that are included. These just seem to be demo files to show how each subcomponent looks.

By not including them for email, I was able to save about 45KB in the application.zip size. Each gaia app likely has these files in them, so the savings is likely compounded by the number of apps including the building blocks.

I have a branch with the change, will attach a pull request once this bug gets and ID.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Removes any .html file in a building block subcomponent. 

Asking :basiclines for review, given experience with build and building blocks, to make sure the .html files are used for something I did not see.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8361340 [details] [review]
GitHub pull request

James, I'll take this one as Ismael is no longer in the project. Peers list should be updated soon :)

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

wow, that's an old PR. 
James, you want to update your PR?
We are also trying to split css files, so we don't have to import unused stuff like themes.
(bug 1000132)

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8361340 [details] [review]
GitHub pull request

Clearing this. Please use r? again in case you want to retake this bug.
Thanks James.

Comment 5

[BMO Automation]

Firefox OS is not being worked on