960811 - enable synthetic APKs by default in Fennec builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: enable synthetic APKs

Once we update Fennec to download APKs from the APK Factory development server (bug 960207), we should enable synthetic APKs by default in Fennec builds.

Here's a patch that does that by setting MOZ_ANDROID_SYNTHAPKS in mobile/android/confvars.sh, which is similar to the way we enable "NFC permission" by setting MOZ_ANDROID_BEAM in that file.  But some other features with compile-time flags are enabled directly in configure.in; let me know if I should do that instead.

I'd like to commit this on Tuesday, January 21, so synthetic APKs make it into Fennec's nightly builds starting Wednesday, January 22.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8361376 [details] [diff] [review]
enable synthetic APKs

I am fine with this approach

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Cool, thanks mfinkle.

Note: I'm still going to hold off committing this until Tuesday, January 21.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c17b4a4199

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c17b4a4199 because it broke Android: 
https://tbpl.mozilla.org/php/getParsedLog.php?id=33421158&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33420964&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33420761&tree=Mozilla-Inbound

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to Wes Kocher (:KWierso) from comment #4)
> I had to back this out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c17b4a4199 because
> it broke Android: 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=33421158&tree=Mozilla-
> Inbound

I'm not sure this failure is related, although the other two were definitely caused by this change.  I filed bug 962858 to figure them out.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #5)
> (In reply to Wes Kocher (:KWierso) from comment #4)
> > I had to back this out in
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c17b4a4199 because
> > it broke Android: 
> > https://tbpl.mozilla.org/php/getParsedLog.php?id=33421158&tree=Mozilla-
> > Inbound
> 
> I'm not sure this failure is related, although the other two were definitely
> caused by this change.  I filed bug 962858 to figure them out.

Hrm, all three showed up on your push, and stayed there until my backout, and then showed back up together on this later push: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b89f28d7f0f9&jobname=android%202.2%20armv6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #6)
> Hrm, all three showed up on your push, and stayed there until my backout,
> and then showed back up together on this later push:
> https://tbpl.mozilla.org/?tree=Mozilla-
> Inbound&rev=b89f28d7f0f9&jobname=android%202.2%20armv6

And then they're gone again in the next push?

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: clobber when enabling synthetic APKs

(In reply to Wes Kocher (:KWierso) from comment #7)
> (In reply to Wes Kocher (:KWierso) from comment #6)
> > Hrm, all three showed up on your push, and stayed there until my backout,
> > and then showed back up together on this later push:
> > https://tbpl.mozilla.org/?tree=Mozilla-
> > Inbound&rev=b89f28d7f0f9&jobname=android%202.2%20armv6
> 
> And then they're gone again in the next push?

I suspect the build system doesn't know that it needs to rebuild files using MOZ_ANDROID_SYNTHAPKS in preprocessor directives when the value of that configuration flag changes, so here's a version of the patch that touches CLOBBER when it enables synthetic APKs.

This is still blocked on the test failures, so it is not ready for commission until the blocker bug is resolved.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Here's a try run with the patch from bug 960811 also applied:

https://tbpl.mozilla.org/?tree=Try&rev=327cc714d889

Comment 10

[Myk Melez [:myk] [@mykmelez]]

The try run looks good, and I just pushed bug 960811 to Inbound.  Assuming it sticks, I'll repush this tomorrow (Sunday, January 26) to enable synthetic APKs on Monday's nightly build.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a9af08f037f

Comment 12

[Myk Melez [:myk] [@mykmelez]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #10)
> The try run looks good, and I just pushed bug 960811 to Inbound.

Erm, I meant to say that I pushed bug 962858 to Inbound.  And it did indeed stick, which is why I pushed this bug to Inbound today, which should mean it gets to Central in time for tomorrow's nightly build (as long as sheriffs do an Inbound -> Central merge this evening).

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a9af08f037f