960845 - compress the png image of bug 869289's patch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

According to the bug 869289 comment 20, we need to compress the PNG image to have smaller image size. Command:

$ ./tools/png_recompress.sh -v apps/video/style/images/default_thumbnail.png \
                               apps/video/style/images/[e-mail] \
                               apps/video/style/images/[e-mail]

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: the compressed png files

George,
This is a image replacement change of bug 869289. Please review this patch. Thanks.

Gabriele,
I had use the command to generate the png files. Please help me to confirm I did correctly. Thanks.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8361466 [details] [review]
the compressed png files

Thanks, John. r=me

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8361466 [details] [review]
the compressed png files

Looks fine to me!

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thank you, guys.

merged to master:
https://github.com/mozilla-b2g/gaia/commit/2490accfc6c29a9be2634ba69bfc500098bcf652

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Gabriele,

Your tool is so amazing. The compression ratio is 0.004. Why does our visual not have it?? We should ask them to use this tool to compress before giving to us.

Comment 6

[Gabriele Svelto [:gsvelto]]

(In reply to John Hu [:johnhu] from comment #5)
> Your tool is so amazing. The compression ratio is 0.004. Why does our visual
> not have it?? We should ask them to use this tool to compress before giving
> to us.

This was an extreme case in that the original PNG file was almost uncompressed. Normally the compression is in the 0.2-0.9 range depending on the image but in general it works better on smaller, simpler images. To see the final impact on our applications you can check bug 959659 comment 5.

One of the reasons such a tool is not commonly used is that it's very, very slow at recompressing; processing large images can take minutes, or even tens of minutes so we prefer to make sure that things are compressed only once when they're finalized and we check them in.

The underlying tools used for compression are optipng: http://optipng.sourceforge.net/ and advancecomp: http://advancemame.sourceforge.net/comp-readme.html