Closed Bug 960899 Opened 10 years ago Closed 10 years ago

add debug function and lldb command to print frame state symbolically

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
      No description provided.
Attachment #8361528 - Flags: review?(dbaron)
Attached patch patch v1.1Splinter Review
Add some docs to python/lldbutils/README.txt too.
Attachment #8361528 - Attachment is obsolete: true
Attachment #8361528 - Flags: review?(dbaron)
Attachment #8361531 - Flags: review?(dbaron)
Comment on attachment 8361531 [details] [diff] [review]
patch v1.1

Please actually test that:
  T* t = do_QueryFrame(f); 
fails if T isn't *itself* a queryframe target?  (It looks like we
have the necessary static_asserts in nsQueryFrame.h)

r=dbaron
Attachment #8361531 - Flags: review?(dbaron) → review+
Yes the static_assert fires, which is how I found I needed to add the couple of queryframe targets in the patch.
This is great! It'd be even greater to use this in frame tree dumps (nsIFrame::List)!
We could do that although it will make the line lengths even longer.  At the moment, with a modest frame depth, I can maximise my terminal and not get (many) line wraps when I dump a frame tree.
I had given up on making frame tree dumps not wrap, so more information was only a plus for me.
https://hg.mozilla.org/integration/mozilla-inbound/rev/191a71ff02bf

tn, can you file a separate bug for sticking this in nsIFrame::List?
(In reply to Cameron McCormack (:heycam) from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/191a71ff02bf
> 
> tn, can you file a separate bug for sticking this in nsIFrame::List?

After I mentioned that I realized that it's not very often I need to look at frame state lately, so if it interferes with others' workflows then I don't feel strongly about it.
https://hg.mozilla.org/mozilla-central/rev/8eca8d49dcb1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.