Allow number pickers that don't stretch the full width in <setting>

RESOLVED FIXED in mozilla29

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

unspecified
mozilla29
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 8361532 [details]
This is silly.

I'm going to set the flex on the <textbox> by CSS instead of an attribute (unless there's a size attribute), and inherit the size attribute from the <setting>.
(Assignee)

Comment 1

4 years ago
Created attachment 8361584 [details] [diff] [review]
960904-1.diff
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #8361584 - Flags: review?(bmcbride)
Attachment #8361584 - Flags: review?(bmcbride) → review+

Comment 3

4 years ago
Comment on attachment 8361584 [details] [diff] [review]
960904-1.diff

>+setting[type="integer"]:not([size]) textbox {
>+  -moz-box-flex: 1;
>+}
I see nobody fusses over descendant selectors any more. Suggestions:

textbox:not([size])
textbox[type="number"]:not([size])
setting[type="integer"] > hbox > textbox:not([size])
https://hg.mozilla.org/mozilla-central/rev/eb1b7ba48d22
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.