Closed
Bug 960904
Opened 11 years ago
Closed 11 years ago
Allow number pickers that don't stretch the full width in <setting>
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(2 files)
|
6.43 KB,
image/png
|
Details | |
|
5.07 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
This is silly.
I'm going to set the flex on the <textbox> by CSS instead of an attribute (unless there's a size attribute), and inherit the size attribute from the <setting>.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8361584 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Flags: in-testsuite+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8361584 [details] [diff] [review]
960904-1.diff
>+setting[type="integer"]:not([size]) textbox {
>+ -moz-box-flex: 1;
>+}
I see nobody fusses over descendant selectors any more. Suggestions:
textbox:not([size])
textbox[type="number"]:not([size])
setting[type="integer"] > hbox > textbox:not([size])
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•