Closed
Bug 960966
Opened 10 years ago
Closed 10 years ago
Remove TelemetryPing.js from telemetry
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: rvitillo, Assigned: rvitillo)
References
Details
Attachments
(1 file, 2 obsolete files)
8.05 KB,
patch
|
Details | Diff | Splinter Review |
The TelemetryPing xpcom component should be removed now that its functionality has been moved to a module.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rvitillo
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8361695 -
Flags: review?(dteller)
Comment 2•10 years ago
|
||
Comment on attachment 8361695 [details] [diff] [review] Remove TelemetryPing.js from telemetry, v1 Review of attachment 8361695 [details] [diff] [review]: ----------------------------------------------------------------- r=me You should probably ask BenWa for a review on parserWorker.js, though.
Attachment #8361695 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8361695 -
Attachment is obsolete: true
Attachment #8363037 -
Flags: review?(bgirard)
Comment 4•10 years ago
|
||
Comment on attachment 8363037 [details] [diff] [review] Remove TelemetryPing.js from telemetry, v2 Review of attachment 8363037 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/profiler/cleopatra/js/parserWorker.js @@ +1274,5 @@ > image: "js.png", > title: "Bug 818274 - [Shutdown] Telemetry takes ~10ms on shutdown", > bugNumber: "818274", > check: function(frames, symbols, meta) { > + return stepContains('TelemetryPing.jsm', frames, symbols) Please leave this out of the patch, this feature isn't used with the built-in profiler.
Attachment #8363037 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8363037 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1532a498286e
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1532a498286e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
Comment 8•10 years ago
|
||
Thunderbird patch: https://hg.mozilla.org/comm-central/rev/7586a9a93b6a (Standard8) SeaMonkey patch: https://hg.mozilla.org/comm-central/rev/fa65d797444e (Ratty)
You need to log in
before you can comment on or make changes to this bug.
Description
•