Closed Bug 960966 Opened 6 years ago Closed 6 years ago

Remove TelemetryPing.js from telemetry

Categories

(Toolkit :: Telemetry, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: rvitillo, Assigned: rvitillo)

References

Details

Attachments

(1 file, 2 obsolete files)

The TelemetryPing xpcom component should be removed now that its functionality has been moved to a module.
Assignee: nobody → rvitillo
Attachment #8361695 - Flags: review?(dteller)
Comment on attachment 8361695 [details] [diff] [review]
Remove TelemetryPing.js from telemetry, v1

Review of attachment 8361695 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
You should probably ask BenWa for a review on parserWorker.js, though.
Attachment #8361695 - Flags: review?(dteller) → review+
Attachment #8361695 - Attachment is obsolete: true
Attachment #8363037 - Flags: review?(bgirard)
Comment on attachment 8363037 [details] [diff] [review]
Remove TelemetryPing.js from telemetry, v2

Review of attachment 8363037 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/profiler/cleopatra/js/parserWorker.js
@@ +1274,5 @@
>      image: "js.png",
>      title: "Bug 818274 - [Shutdown] Telemetry takes ~10ms on shutdown",
>      bugNumber: "818274",
>      check: function(frames, symbols, meta) {
> +      return stepContains('TelemetryPing.jsm', frames, symbols)

Please leave this out of the patch, this feature isn't used with the built-in profiler.
Attachment #8363037 - Flags: review?(bgirard) → review+
Blocks: 839794
https://hg.mozilla.org/mozilla-central/rev/1532a498286e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.