960966 - Remove TelemetryPing.js from telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Roberto Agostino Vitillo (:rvitillo)]

The TelemetryPing xpcom component should be removed now that its functionality has been moved to a module.

Comment 1

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Remove TelemetryPing.js from telemetry, v1

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8361695 [details] [diff] [review]
Remove TelemetryPing.js from telemetry, v1

Review of attachment 8361695 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
You should probably ask BenWa for a review on parserWorker.js, though.

Comment 3

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Remove TelemetryPing.js from telemetry, v2

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8363037 [details] [diff] [review]
Remove TelemetryPing.js from telemetry, v2

Review of attachment 8363037 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/profiler/cleopatra/js/parserWorker.js
@@ +1274,5 @@
>      image: "js.png",
>      title: "Bug 818274 - [Shutdown] Telemetry takes ~10ms on shutdown",
>      bugNumber: "818274",
>      check: function(frames, symbols, meta) {
> +      return stepContains('TelemetryPing.jsm', frames, symbols)

Please leave this out of the patch, this feature isn't used with the built-in profiler.

Comment 5

[Roberto Agostino Vitillo (:rvitillo)]

Attachment: Remove TelemetryPing.js from telemetry, v3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1532a498286e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1532a498286e

Comment 8

[Philip Chee]

Thunderbird patch: https://hg.mozilla.org/comm-central/rev/7586a9a93b6a (Standard8)
SeaMonkey patch: https://hg.mozilla.org/comm-central/rev/fa65d797444e (Ratty)