Closed
Bug 960968
Opened 11 years ago
Closed 11 years ago
Make building PDF documentation optional, off by default
Categories
(Bugzilla :: Documentation, defect)
Bugzilla
Documentation
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: gerv, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
551 bytes,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
Building the PDF docs requires 1GB of TeX. Most people will not read the PDF. readthedocs.org automatically builds the PDFs for us so we can check them every so often - and as long as we use standard RST/Sphinx markup, there shouldn't be problems anyway.
All these things make me think that building the PDFs should be an option, and off by default. (I.e. you should need to pass a parameter to makedocs.pl in order to build them.)
Gerv
Assignee | ||
Comment 1•11 years ago
|
||
You regressed this in bug 912064. You removed
if (! grep($_ eq "--with-pdf", @ARGV)) {
next;
}
Assignee | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 8361847 [details] [diff] [review]
patch, v1
Oops, sorry. Over-eager removal of what I thought was the old stuff. r=gerv. Thanks :-)
Gerv
Attachment #8361847 -
Flags: review?(gerv) → review+
Assignee | ||
Updated•11 years ago
|
Flags: approval?
Reporter | ||
Comment 4•11 years ago
|
||
This change is also in bug 961755, in case that one gets checked in first.
Gerv
Reporter | ||
Comment 5•11 years ago
|
||
Fixed in bug 961775.
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified docs/makedocs.pl
Committed revision 8874.
Gerv
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•