960997 - DOMWebNotificationClicked message handler should do window.focus() instead of setting focusManager.activeWindow = window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

In tabbrowser.xml, the DOMWebNotificationClicked message handler gets the focus manager and then sets focusManager.activeWindow = window in order to bring the window to the front:

http://hg.mozilla.org/mozilla-central/annotate/9bcc52594322/browser/base/content/tabbrowser.xml#l2973

It should instead call window.focus, which is simpler.

Comment 1

[AK]

May I please be assigned to this bug? Also, for clarification, you're saying that the current window should be focused using the window object itself, rather than setting it as the activeWindow using focusManager, correct? 

Therefore the two lines:

   let focusManager = Cc["@mozilla.org/focus-manager;1"].getService(Ci.nsIFocusManager);
   focusManager.activeWindow = window;

should be changed to simply:

   window.focus();

Comment 2

[Peiyong Lin[:lpy](UTC+8)]

Hi AK. It's yours now.

Comment 3

[AK]

Attachment: Change tabbrowser.xml DOMWebNotificationClicked handler to use windows.focus()

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8361980 [details] [diff] [review]
Change tabbrowser.xml DOMWebNotificationClicked handler to use windows.focus()

thanks!

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/f8b4174ffc65

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f8b4174ffc65