Closed
Bug 961034
Opened 10 years ago
Closed 10 years ago
Collect UITelemetry on how many times the Australis menu button is clicked.
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [Australis:P-])
Attachments
(1 file)
3.70 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
See summary.
Assignee | ||
Comment 1•10 years ago
|
||
I believe this is the last one of these from me. At least for the foreseeable future.
Attachment #8362629 -
Flags: review?(gijskruitbosch+bugs)
Comment 2•10 years ago
|
||
Comment on attachment 8362629 [details] [diff] [review] Patch v1 Review of attachment 8362629 [details] [diff] [review]: ----------------------------------------------------------------- Note that this will pick up clicking the item in customize mode. Do we want that? Do we want to distinguish that from the other cases? If we're using that as the detail, do we care about which mouse button the user uses? (r=me assuming this does what we want)
Attachment #8362629 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Blake: Do you care about the case that Gijs has brought up - clicking of the menu panel button while in customize mode?
Flags: needinfo?(bwinton)
Comment 4•10 years ago
|
||
I don't think we need to distinguish it. It's kind of interesting, but not interesting enough to do extra work to track at this point. (And I strongly suspect the clicks that we are tracking will totally swamp the noise of the button being clicked in customize mode.) I do reserve the right to re-visit this after Australis lands, if we hear a lot of reports of people trying to click buttons in customize mode. ;)
Flags: needinfo?(bwinton)
Assignee | ||
Comment 5•10 years ago
|
||
Ok, thanks - then I'm gonna just go for it and land this puppy (which closes out the stuff that's blocking Australis). Thanks, you two!
Assignee | ||
Comment 6•10 years ago
|
||
Landed on fx-team as: remote: https://hg.mozilla.org/integration/fx-team/rev/cf528dfe5797
Whiteboard: [Australis:P-] → [Australis:P-][fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf528dfe5797
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P-][fixed-in-fx-team] → [Australis:P-]
Target Milestone: --- → Firefox 29
You need to log in
before you can comment on or make changes to this bug.
Description
•