Update HomeListsProvider to use the SQLiteBridge

RESOLVED FIXED in Firefox 29

Status

()

Firefox for Android
Data Providers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 29
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In bug 942288, we're using Sqlite.jsm to store data for home panels. We should update (and rename) HomeListsProvider to pull data from this DB when it does DB queries.

I want us to land bug 947506 before working on this, to make the naming more straightforward.
(Assignee)

Comment 1

4 years ago
I started a patch for this.
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 2

4 years ago
Created attachment 8364094 [details] [diff] [review]
patch

With this patch, testHomeListsProvider still passes locally, but I haven't tried writing any tests to exercise the actual DB interaction part of this.

I also want to file a bug to rename HomeListsProvider -> HomeProvider, and rename/update the HomeListItems columns we have in BrowserContract to reflect what we're doing in HomeProvider.jsm.
Attachment #8364094 - Flags: review?(wjohnston)
(Assignee)

Updated

4 years ago
Blocks: 952310
Comment on attachment 8364094 [details] [diff] [review]
patch

Review of attachment 8364094 [details] [diff] [review]:
-----------------------------------------------------------------

This is a happy patch.

::: mobile/android/base/db/HomeListsProvider.java
@@ -71,5 @@
> -
> -    private boolean isTest(Uri uri) {
> -        String isTest = uri.getQueryParameter(BrowserContract.PARAM_IS_TEST);
> -        return !TextUtils.isEmpty(isTest);
> -    }

You'd be welcome to move any of this you wanted into the bridge provider....
Attachment #8364094 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/daa0d522ed53
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.