961154 - When a second incoming call occurs, it does not turn the screen on

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Salem Elkabule]

Attachment: Dialer.txt

Description:
When the user is on an active call and opens the speaker and wait for the screen to go to sleep, make a call with a third device to the test device. The screen doesn't automatically turn on informing the user there’s a second call 

Repro Steps:
1) Updated Buri 1.3 Moz Ril
2) Make a Call from another device to DUT 
3) Answer the call and open the speaker
4) Let the device screen go to sleep
5) From a third device make a call to a DUT 

Actual:
There is no visual indication that there’s an incoming call

Expected:
The screen should automatically turn on, to inform the user for an incoming call

Environmental Variables
Device: buri 1.3 Moz Ril
Build ID: 20140117004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/2c033140eff4
Gaia: a81ccdc53e45a6adeaae423e104e91bcc1e12b0e
Platform Version: 28.0a2
Device firmware version: V1.2-device.cfg

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/8489/
See attached: Logcat

Comment 1

[Salem Elkabule]

This issue was Verified fix On bug#915071 But issue still reproduces on buri 1.2 

1.2 
Environmental VariablesDevice:
Build ID: 20140114004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/42a1c35fc831
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
Device firmware version: V1.2-device.cfg

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on a Leo 1.3 build? Trying to isolate if this is a device-specific bug.

Comment 3

[Salem Elkabule]

This issue reproduces on Leo 1.3 

Environmental Variables
Device: Leo 1.3 moz ril
Build ID: 20131120062258
Gecko: http://hg.mozilla.org/mozilla-central/rev/597287004ff5
Gaia: c26480b22ce28c812c347290dd4bad090d83db6f
Platform Version: 28.0a1
Firmware Version: v10d 

There is no visual indication that there’s an incoming call

Comment 4

[Jason Smith [:jsmith]]

Okay - does this reproduce on 1.1?

Comment 5

[Salem Elkabule]

This issue reproduces on both Leo1.1 and buri1.1
1.1
Environmental Variables
Device: buri 1.1 moz ril
Build ID: 20140115041456
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/0a2e7ed17611
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
Firmware Version: v1.2-device.cfg

Leo 1.1
Environmental Variables
Device: Leo 1.1 moz ril
Build ID: 20131218041200
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/bdac595a4e46
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
Firmware Version: v10d

Comment 8

[Anthony Ricaud (:rik)]

This has (at least) two duplicates, the last one being opened during Flame test run. Let's fix it!

Comment 9

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21939

Comment 10

[Anthony Ricaud (:rik)]

I tried to factor the screen management suites but couldn't get it to work. If you have a way to do so, I'll happily do it.

Comment 11

[Doug Sherk (:drs) (inactive)]

Attachment: Screen management refactor on top of PR

LGTM. I attached a patch that does this refactor, but it's incomplete and causes conflicts in names, such as "mockCall" in different scopes, so you might want to fix that and re-request review.

Comment 12

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8458812 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21939

Clearing review until the refactor is done. If you don't like the way I did it, feel free to re-request with the PR as-is.

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8458812 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21939

Thanks for giving it a try. I took a look at it and renaming extraCall to mockCall makes the tests less readable imho. I'd like to go with something DRY but it has to stay readable. Julien proposed to pass a function that returns the call under test but that also feels more boilerplate than necessary for tests.

Comment 14

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/18d18d1f840e7d93ffd5cf211b173ff52b466df7

Comment 15

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Removing the affected flag for 2.1 as this was closed a long time ago. Another bug should be opened if this issue is occuring again.