Closed Bug 961191 Opened 8 years ago Closed 7 years ago

New Jetpack CLI (JPM) JEP

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

(Whiteboard: [status:landedon])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
evold
: feedback+
irakli
: feedback-
zer0
: feedback+
canuckistani
: feedback+
KWierso
: feedback+
mossop
: feedback+
Details | Review
No description provided.
Attached file JPM JEP
Attachment #8363200 - Flags: feedback?(zer0)
Attachment #8363200 - Flags: feedback?(rFobic)
Attachment #8363200 - Flags: feedback?(kwierso)
Attachment #8363200 - Flags: feedback?(jgriffiths)
Attachment #8363200 - Flags: feedback?(evold)
Attachment #8363200 - Flags: feedback?(dtownsend+bugmail)
Comment on attachment 8363200 [details] [review]
JPM JEP

Looks good to me.
Attachment #8363200 - Flags: feedback?(kwierso) → feedback+
Comment on attachment 8363200 [details] [review]
JPM JEP

Looks good to me!  Although maybe we should mention what to do with the experimental options.
Attachment #8363200 - Flags: feedback?(evold) → feedback+
Regarding the experimental options currently in CFX, all are listed in the JEP (and categorized by implement, eventually implement, and should not implement)
Merged current feedback into JEP so far
Attachment #8363200 - Flags: feedback?(jgriffiths) → feedback+
Attachment #8363200 - Flags: feedback?(dtownsend+bugmail) → feedback+
Attachment #8363200 - Flags: feedback?(zer0) → feedback+
Comment on attachment 8363200 [details] [review]
JPM JEP

Putting f- just to indicate that we need to update this pull by reducing
features.
Attachment #8363200 - Flags: feedback?(rFobic) → feedback-
Depends on: 1004833
(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #6)
> Comment on attachment 8363200 [details] [review]
> JPM JEP
> 
> Putting f- just to indicate that we need to update this pull by reducing
> features.

I just read over the comments in this pull request and I can't figure out why you f- this Irakli.  Can we get this JEP finished so that we can release this?
Flags: needinfo?(rFobic)
Flags: needinfo?(jsantell)
I believe that either Erik or Jordan are going to go through the pull request to address or object to some of the comments in there. Once that's done feel free to re-request feedback.
Flags: needinfo?(rFobic)
So in the meeting yesterday I believe Irakli said this was done, but it does not appear to have been merged yet.
Flags: needinfo?(rFobic)
This is now merged; closing
Flags: needinfo?(rFobic)
Flags: needinfo?(jsantell)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [status:landedon]
You need to log in before you can comment on or make changes to this bug.