961223 - Character encoding in app bar: implement it or remove it from Options

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly 29.0a1 2014-01-17 on Windows 8.1 Pro 64 bit

In Firefox Metro's options, there is a switch to show a menu for choosing the character encoding in the app bar.
This hasn't be implemented yet (see bug 848251 comment 2), so either implement it or remove it from the preferences.

Comment 1

[Allison Naaktgeboren :ally]

Attachment: removeCharacterPref

I left the strings alone purposely since we'll use them when the feature is implemented. No sense in wasting localizers' work.

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8363874 [details] [diff] [review]
removeCharacterPref

Review of attachment 8363874 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Allison Naaktgeboren :ally]

Thank you for reviewing. :)

https://hg.mozilla.org/integration/fx-team/rev/a9913c62d98a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9913c62d98a

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0a65845cfbdd

Comment 6

[Manuela Muntean [Away]]

Could you please give some guidance in order for the QA to verify this? Thanks!

Comment 7

[Allison Naaktgeboren :ally]

Open metro, open Options charm
Should not see an entry in options for "Character Encoding"

Comment 8

[Manuela Muntean [Away]]

(In reply to :Ally Naaktgeboren from comment #7)
> Open metro, open Options charm
> Should not see an entry in options for "Character Encoding"

Thanks Ally!

Verified as fixed, for iteration #23, with both latest Nightly and Aurora on Win 8.1 64-bit.