Closed Bug 961223 Opened 7 years ago Closed 7 years ago

Character encoding in app bar: implement it or remove it from Options

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(firefox28 verified, firefox29 verified)

VERIFIED FIXED
Firefox 29
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: aryx, Assigned: ally)

References

Details

(Whiteboard: [beta28] [defect] p=2)

Attachments

(1 file)

Firefox Nightly 29.0a1 2014-01-17 on Windows 8.1 Pro 64 bit

In Firefox Metro's options, there is a switch to show a menu for choosing the character encoding in the app bar.
This hasn't be implemented yet (see bug 848251 comment 2), so either implement it or remove it from the preferences.
Whiteboard: [testday-20140117] → [testday-20140117] [triage] [defect] p=0
Whiteboard: [testday-20140117] [triage] [defect] p=0 → [beta28] [defect] p=0
Assignee: nobody → ally
Whiteboard: [beta28] [defect] p=0 → [beta28] [defect] p=2
Blocks: metrov1it23
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Summary: Character encoding in app bar: implement it or remove it from settings/options/preferences → Character encoding in app bar: implement it or remove it from Options
I left the strings alone purposely since we'll use them when the feature is implemented. No sense in wasting localizers' work.
Attachment #8363874 - Flags: review?(azasypkin)
Comment on attachment 8363874 [details] [diff] [review]
removeCharacterPref

Review of attachment 8363874 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8363874 - Flags: review?(azasypkin) → review+
https://hg.mozilla.org/mozilla-central/rev/a9913c62d98a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Could you please give some guidance in order for the QA to verify this? Thanks!
Flags: needinfo?(ally)
Open metro, open Options charm
Should not see an entry in options for "Character Encoding"
Flags: needinfo?(ally)
(In reply to :Ally Naaktgeboren from comment #7)
> Open metro, open Options charm
> Should not see an entry in options for "Character Encoding"

Thanks Ally!

Verified as fixed, for iteration #23, with both latest Nightly and Aurora on Win 8.1 64-bit.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.