961265 - Changeset-oriented review tool

Status: RESOLVED DUPLICATE of bug 1021929

(mozilla.org :: Project Review, task)

Description

[(dormant account)]

Initial Questions:

Project/Feature Name: Changeset-oriented review tool
Tracking  ID:
Description:
Problem: our code review tooling is inefficient from developer perspective and infrastructure perspective:
* A proper review tool is key to implementing autoland(https://wiki.mozilla.org/ReleaseEngineering:Autoland) in way that simplifies the rest of our infrastructure
* properly implemented review + autoland process will let us get rid of mozilla-inbound, and redundant try runs.
** This means faster turnarounds
** Up to 50% savings in our infrastructure load
* This will save developers a lot of time, possibly hours per week.

Additional Information:
https://github.com/ehsan/reviewtool
Key Initiative: Firefox Platform
Release Date: 2014-02-01
Project Status: active
Mozilla Data: No
Mozilla Related: Bugzilla, hg.mozilla.org, Release Process
Separate Party: Yes
Type of Relationship: Other
Data Access: No
Privacy Policy: 
Vendor Cost: <= $25,000

Comment 1

[(dormant account)]

Bug 961266 - Legal Review: Changeset-oriented review tool

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Not sure if I should bring this up here, but thought I might anyway (cross posted from bug 947596):

Over the weekend, smacleod and I hacked on a mechanism for creating Review Board review requests with a push-based work flow.

This only took us a few hours, and is mostly a proof-of-concept. There are some edge cases and concerns that we'll need to deal with, but we feel pretty good about what we came up with:

Demo video: https://vimeo.com/86448355
Code: https://github.com/mikeconley/rb-repo

Feedback welcome in bug 947596!

Comment 3

[(no longer active)]

(In reply to comment #2)
> Not sure if I should bring this up here, but thought I might anyway (cross
> posted from bug 947596):
> 
> Over the weekend, smacleod and I hacked on a mechanism for creating Review
> Board review requests with a push-based work flow.
> 
> This only took us a few hours, and is mostly a proof-of-concept. There are some
> edge cases and concerns that we'll need to deal with, but we feel pretty good
> about what we came up with:
> 
> Demo video: https://vimeo.com/86448355
> Code: https://github.com/mikeconley/rb-repo
> 
> Feedback welcome in bug 947596!

FWIW we're going ahead with RB.