961346 - Incorrect parsing of of midnight hour for FTP directory list in DOS format

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Kevin Locke]

Attachment: Fix FTP date parsing of midnight for DOS format

File modification times between 12:00 AM and 12:59 AM in FTP directory listings in DOS format are incorrectly parsed as being between 12:00 PM and 12:59 PM due to a missing case in the AM/PM to 0-23 conversion for the midnight hour.

For example, the following directory listing is parsed as 12:25 PM rather than AM:

01-11-14  12:25AM             18864566 testfile.zip

I can confirm that this bug is present in version 24 and trunk (and presumably has been for quite some time before that).  The fix is pretty trivial.  I've included a patch.

Cheers,
Kevin

Comment 1

[Patrick McManus [:mcmanus]]

Comment on attachment 8362052 [details] [diff] [review]
Fix FTP date parsing of midnight for DOS format

Review of attachment 8362052 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm - thanks for the patch

Comment 2

[Kevin Locke]

My pleasure, thanks for reviewing it!

Comment 3

[Masatoshi Kimura [:emk]]

Waiting for the try result: https://tbpl.mozilla.org/?tree=Try&rev=da767e28f028

Comment 4

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c21b94a7775

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c21b94a7775