961363 - focused <select size=1> picklist (combobox) blocks hotkey (ctrl+pgup/pgdown) tab switching

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[lvm]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Firefox/25.0 SeaMonkey/2.22.1 (Beta/Release)
Build ID: 20131113180410

Steps to reproduce:

1. open a new tab (tab1)
2. open a document with <select> picklist (e.g. this bug submission page https://bugzilla.mozilla.org/enter_bug.cgi#h=bugForm|SeaMonkey) in a second tab (tab2)
3. click on the picklist (e.g. "version:" picklist) to focus it
4. click on a tab header of tab1 to switch to tab1
5. press ^pgdn to switch to tab2
6. press ^pgup to switch back to tab1



Actual results:

switching to tab1 in step 6 does not work, also reproducible in firefox 26.0 linux 32

Comment 1

[Phoenix]

Same on Windows, moving to Core, not sure if this category is right

Comment 2

[Mats Palmgren (inactive)]

Attachment: fix

The added early return is what fixes this bug.

Adding HOME/END to the if-condition below it is a minor bug fix
for CTRL+HOME/END for single-select lists that I discovered.
We should map those to their non-CTRL behavior just like UP etc.

("single-select" here meaning comboboxes, or non-multiple lists)

Comment 3

[Mats Palmgren (inactive)]

Attachment: mochitest

https://tbpl.mozilla.org/?tree=Try&rev=96cc8da3bb30
https://tbpl.mozilla.org/?tree=Try&rev=06190db096f8

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8362377 [details] [diff] [review]
fix

r=me

Comment 5

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7676f94f42e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/875995978eab

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7676f94f42e7
https://hg.mozilla.org/mozilla-central/rev/875995978eab

Comment 7

[lvm]

Another bug which may be related: when <select size=1> picklist is focused in the current tab ^F4 doesn't close the tab but toggles the picklist instead (tested on seamonkey 2.22.1 for windows 32). Is it fixed in this bug or should I create a new one?

Comment 8

[Mats Palmgren (inactive)]

(In reply to lvm from comment #7)
> Another bug which may be related: when <select size=1> picklist is focused
> in the current tab ^F4 doesn't close the tab but toggles the picklist

Please file a separate bug.