961412 - Back out bug 849526

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Now that exact rooting has landed, we shouldn't need hacks like this. Let's wait a few days to make sure it sticks and then take it out. As far as I know, this patch never had any effect on ARM, so we shouldn't need to wait until b2g has exact rooting.

Comment 1

[Terrence Cole [:terrence]]

Attachment: backout_bug_849526-v0.diff

The RSS for the testcase does stay at 320MiB, although I can't exactly test with --no-jm these days.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8431205 [details] [diff] [review]
backout_bug_849526-v0.diff

Review of attachment 8431205 [details] [diff] [review]:
-----------------------------------------------------------------

Great to see this go, thanks.

Really glad our GC roots no longer depend on the C++ compiler's codegen.

Comment 3

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3dfab38899

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ad3dfab38899