Closed Bug 961412 Opened 7 years ago Closed 7 years ago

Back out bug 849526

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: billm, Assigned: terrence)

References

Details

Attachments

(1 file)

Now that exact rooting has landed, we shouldn't need hacks like this. Let's wait a few days to make sure it sticks and then take it out. As far as I know, this patch never had any effect on ARM, so we shouldn't need to wait until b2g has exact rooting.
Blocks: 795030
The RSS for the testcase does stay at 320MiB, although I can't exactly test with --no-jm these days.
Assignee: nobody → terrence
Status: NEW → ASSIGNED
Attachment #8431205 - Flags: review?(jdemooij)
Comment on attachment 8431205 [details] [diff] [review]
backout_bug_849526-v0.diff

Review of attachment 8431205 [details] [diff] [review]:
-----------------------------------------------------------------

Great to see this go, thanks.

Really glad our GC roots no longer depend on the C++ compiler's codegen.
Attachment #8431205 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/ad3dfab38899
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.