Closed Bug 961481 Opened 7 years ago Closed 7 years ago

regression: panorama icon is not displayed on tabbar

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 29

People

(Reporter: tetsuharu, Assigned: mmaslaney)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Australis:P1])

Attachments

(2 files)

Attached image screenshot
[env]
- http://hg.mozilla.org/mozilla-central/rev/61fd0f987cf2
- OSX 10.9


panorama icon is not displayed on tabbar.
This's caused by that new `/browser/themes/osx/Toolbar.png` does not have the icon for panorama toolbar:
https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/Toolbar.png
Blocks: 888601
Keywords: regression
This is only on non-hidpi. I checked the assets in bug 888601, and it seems the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip file, either. Michael, can you pick this up, please? :-)
Assignee: nobody → mmaslaney
Status: NEW → ASSIGNED
Whiteboard: [Australis:P1]
(In reply to :Gijs Kruitbosch from comment #1)
> This is only on non-hidpi. I checked the assets in bug 888601, and it seems
> the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip
> file, either. Michael, can you pick this up, please? :-)

I think we have same issue on hidpi: https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/Toolbar%402x.png
(In reply to Tetsuharu OHZEKI [UTC+9] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > This is only on non-hidpi. I checked the assets in bug 888601, and it seems
> > the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip
> > file, either. Michael, can you pick this up, please? :-)
> 
> I think we have same issue on hidpi:
> https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/
> Toolbar%402x.png

No, we don't. I tested my patch on hidpi; it's the last icon in the row:

https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/osx/Toolbar%402x.png
(In reply to :Gijs Kruitbosch from comment #3)
> No, we don't. I tested my patch on hidpi; it's the last icon in the row:
> 
> https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/
> osx/Toolbar%402x.png

Ok. sorry. I mixed up.
(In reply to Tetsuharu OHZEKI [UTC+9] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > No, we don't. I tested my patch on hidpi; it's the last icon in the row:
> > 
> > https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/
> > osx/Toolbar%402x.png
> 
> Ok. sorry. I mixed up.

No worries, thanks for making me check again! :-)

If anyone sees this on Windows 7, that's bug 961532 and fixed on fx-team, so hopefully fixed for tomorrow's (or the next) nightly, too.
Assignee: mmaslaney → nobody
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Michael, are you sure? I'm pretty sure the OS X non-hidpi issue is still not fixed. :-)
Flags: needinfo?(mmaslaney)
Attached image Toolbar.png
Oh snap. Sorry, was in the "copy and paste" vortex when putting the original zip file together.
Flags: needinfo?(mmaslaney)
(In reply to mmaslaney from comment #7)
> Created attachment 8363241 [details]
> Toolbar.png
> 
> Oh snap. Sorry, was in the "copy and paste" vortex when putting the original
> zip file together.

's ok, thanks for the file!
Assignee: nobody → gijskruitbosch+bugs
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
As this is just about the image file, I'm going to go and say you wrote the patch here, and I reviewed it:

remote:   https://hg.mozilla.org/integration/fx-team/rev/66c65cf6e7c5

:-)
Assignee: gijskruitbosch+bugs → mmaslaney
Status: REOPENED → ASSIGNED
Whiteboard: [Australis:P1] → [Australis:P1][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/66c65cf6e7c5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 29
QA Contact: cornel.ionce
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0		
Build ID: 20140327113732

The panorama icon is properly displayed on the tab bar using 29 beta 3.
Marking verfied.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.