961481 - regression: panorama icon is not displayed on tabbar

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot

[env]
- http://hg.mozilla.org/mozilla-central/rev/61fd0f987cf2
- OSX 10.9


panorama icon is not displayed on tabbar.
This's caused by that new `/browser/themes/osx/Toolbar.png` does not have the icon for panorama toolbar:
https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/Toolbar.png

Comment 1

[:Gijs (he/him)]

This is only on non-hidpi. I checked the assets in bug 888601, and it seems the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip file, either. Michael, can you pick this up, please? :-)

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to :Gijs Kruitbosch from comment #1)
> This is only on non-hidpi. I checked the assets in bug 888601, and it seems
> the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip
> file, either. Michael, can you pick this up, please? :-)

I think we have same issue on hidpi: https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/Toolbar%402x.png

Comment 3

[:Gijs (he/him)]

(In reply to Tetsuharu OHZEKI [UTC+9] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > This is only on non-hidpi. I checked the assets in bug 888601, and it seems
> > the icon isn't in the OSX non-hidpi Toolbar.png that's provided in the zip
> > file, either. Michael, can you pick this up, please? :-)
> 
> I think we have same issue on hidpi:
> https://hg.mozilla.org/mozilla-central/file/5324dac4d4b4/browser/themes/osx/
> Toolbar%402x.png

No, we don't. I tested my patch on hidpi; it's the last icon in the row:

https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/osx/Toolbar%402x.png

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to :Gijs Kruitbosch from comment #3)
> No, we don't. I tested my patch on hidpi; it's the last icon in the row:
> 
> https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/
> osx/Toolbar%402x.png

Ok. sorry. I mixed up.

Comment 5

[:Gijs (he/him)]

(In reply to Tetsuharu OHZEKI [UTC+9] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > No, we don't. I tested my patch on hidpi; it's the last icon in the row:
> > 
> > https://hg.mozilla.org/mozilla-central/raw-file/5324dac4d4b4/browser/themes/
> > osx/Toolbar%402x.png
> 
> Ok. sorry. I mixed up.

No worries, thanks for making me check again! :-)

If anyone sees this on Windows 7, that's bug 961532 and fixed on fx-team, so hopefully fixed for tomorrow's (or the next) nightly, too.

Comment 6

[:Gijs (he/him)]

Michael, are you sure? I'm pretty sure the OS X non-hidpi issue is still not fixed. :-)

Comment 7

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Toolbar.png

Oh snap. Sorry, was in the "copy and paste" vortex when putting the original zip file together.

Comment 8

[:Gijs (he/him)]

(In reply to mmaslaney from comment #7)
> Created attachment 8363241 [details]
> Toolbar.png
> 
> Oh snap. Sorry, was in the "copy and paste" vortex when putting the original
> zip file together.

's ok, thanks for the file!

Comment 9

[:Gijs (he/him)]

As this is just about the image file, I'm going to go and say you wrote the patch here, and I reviewed it:

remote:   https://hg.mozilla.org/integration/fx-team/rev/66c65cf6e7c5

:-)

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66c65cf6e7c5

Comment 11

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0		
Build ID: 20140327113732

The panorama icon is properly displayed on the tab bar using 29 beta 3.
Marking verfied.