961485 - [gonk-kk][wifi] wifi doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Wifi network list isn't displayed, and always display scanning.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-961485-fix.patch

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8362333 [details] [diff] [review]
bug-961485-fix.patch

Review of attachment 8362333 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiUtils.cpp
@@ +242,5 @@
> +  DEFINE_DLFUNC(wifi_command, int32_t, const char*, char*, size_t*)
> +  int32_t do_wifi_command(const char* iface, const char* cmd, char* buf, size_t* len) {
> +    char command[COMMAND_SIZE];
> +    if (!strcmp(iface,"p2p0")) {
> +      // commands for p2p0 interface don't need prefix

Nit: capitalize the first letter, period at the end of the sentence please.

::: dom/wifi/WifiWorker.js
@@ +636,5 @@
> +    if (event.indexOf("IFNAME=") === 0)
> +    {
> +      // Jump over IFNAME for gonk-kk.
> +      event = event.substr(event.indexOf(" ") + 1);
> +    }

Can you explain why do we need this ?

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

In gonk-kk, the in coming event is in this format "IFNAME=wlan0 CTRL-EVENT-......".

This will break consecutive condition check and always enter this checking and return;

    if (event.indexOf("CTRL-EVENT-") !== 0 && event.indexOf("WPS") !== 0) { 
      ...
    }

Comment 4

[Vincent Chang[:vchang][changyihsin]]

(In reply to Kai-Zhen Li from comment #3)
> In gonk-kk, the in coming event is in this format "IFNAME=wlan0
> CTRL-EVENT-......".
> 
> This will break consecutive condition check and always enter this checking
> and return;
> 
>     if (event.indexOf("CTRL-EVENT-") !== 0 && event.indexOf("WPS") !== 0) { 
>       ...
>     }

How do you think if we move version dependent codes to WifiUtils.cpp ?

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Hanlde IFNAME of wifi command for gonk-kk

Have version dependent codes in cpp files.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Hanlde IFNAME of wifi command for gonk-kk

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8362750 [details] [diff] [review]
Hanlde IFNAME of wifi command for gonk-kk

Review of attachment 8362750 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit fixed.

::: dom/wifi/WifiUtils.cpp
@@ +241,5 @@
> +
> +  DEFINE_DLFUNC(wifi_command, int32_t, const char*, char*, size_t*)
> +  int32_t do_wifi_command(const char* iface, const char* cmd, char* buf, size_t* len) {
> +    char command[COMMAND_SIZE];
> +    if (!strcmp(iface,"p2p0")) {

nit: space after ','

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Hanlde IFNAME of wifi command for gonk-kk

fixed nit and update reviewer.

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=a1a678411ae8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5241207fcb41

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5241207fcb41