Closed Bug 961522 Opened 7 years ago Closed 7 years ago

[ftu] typos in ftu: "pckodeLabel" should be "spckcodeLabel", "messasges" should be "messages"

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached file pull request
The changes which landed in bug 926347 have some issues. I didn't change the text label keys/entities because it's either a typo fix or uses the correct label used in Settings which localizers also should look up from theirs locales.
Attachment #8362279 - Flags: review?(arcturus)
Comment on attachment 8362279 [details] [review]
pull request

Sending the review to my official bugzilla account :)
Attachment #8362279 - Flags: review?(arcturus) → review?(francisco.jordano)
Pike

Please check if you agree that this is a late l10n issue.
Flags: needinfo?(l10n)
Keywords: late-l10n
Comment on attachment 8362279 [details] [review]
pull request

For 1.3, I think we should leave the typo in the key. We should fix that typo on master, though.

The typo in simDefaultMessage is OK to fix.

The change to simSettingsMessage should have a key change, and I don't think it should land on 1.3.

I don't think I fully grokked how this relates to bug 926347, though. The diff there seems to overlap only partially.
Flags: needinfo?(l10n)
I've been syncing with Kaze as well, and now that we have translations for the labels with typos, is just the label we will need to retransalte again.

Definitely not a 1.3+, but will leave to the l10n guys to decide if we correct the typo in the labels and  retranslate.

Thanks.
My comment 5 should answer that.
blocking-b2g: 1.3? → backlog
(In reply to Axel Hecht [:Pike] from comment #5)
> For 1.3, I think we should leave the typo in the key. We should fix that
> typo on master, though.
So should I alter the calls to this key so that they used the typo version?

> I don't think I fully grokked how this relates to bug 926347, though. The
> diff there seems to overlap only partially.
I checked and all changes in my pull request touch changes from bug 926347
(In reply to Archaeopteryx [:aryx] from comment #8)
> (In reply to Axel Hecht [:Pike] from comment #5)
> > For 1.3, I think we should leave the typo in the key. We should fix that
> > typo on master, though.
> So should I alter the calls to this key so that they used the typo version?
Forget it, it's not used in 1.3.
Attached patch pull request for 1.3, v1 (obsolete) — Splinter Review
Attachment #8363994 - Flags: review?(francisco.jordano)
Attached file pull request for 1.3, v2 (obsolete) —
Attachment #8363994 - Attachment is obsolete: true
Attachment #8363994 - Flags: review?(francisco.jordano)
Attachment #8363995 - Flags: review?(francisco.jordano)
Comment on attachment 8362279 [details] [review]
pull request

r+ but not a blocker for 1.3
Attachment #8362279 - Flags: review?(francisco.jordano) → review+
blocking-b2g: backlog → ---
Comment on attachment 8363995 [details] [review]
pull request for 1.3, v2

IMHO, not a blocker for 1.3
Attachment #8363995 - Flags: review?(francisco.jordano) → review-
Master: ac8a273809b5b160554e616bc5ef2d6fa026ce0e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.