96154 - Remove |class="outlinercol-header outlinercol-inset-header"| from <outlinercol>'s

Status: VERIFIED FIXED

(Core :: XUL, defect, P4)

Description

[John Morrison]

I just happened to notice that while we typically set the 'class' attribute 
of <outlinercol>'s to include "outlinercol-header outlinercol-inset-header", 
there are no CSS rules that refer to those classes, nor anywhere else in 
the code (that I can see) where we use those attributes:
 
  http://lxr.mozilla.org/seamonkey/search?string=outlinercol-header
  http://lxr.mozilla.org/seamonkey/search?string=outlinercol-inset-header

The files that have these (apparently) redundant classes are:

  /extensions/venkman/resources/content/venkman.xul
  /mailnews/base/resources/content/folderPane.xul
  /mailnews/base/resources/content/msgSelectOffline.xul
  /mailnews/base/resources/content/subscribe.xul
  /mailnews/base/resources/content/threadPane.xul
  /xpfe/components/bookmarks/resources/oTest.xul
  /xpfe/components/filepicker/res/content/filepicker.xul

hyatt and bryner don't seem to know why those class attributes are in there.
Is there a need for them, or are they just cruft that is left over from 
tree->outliner conversions (and copy-pasted into later conversions).

Comment 1

[John Morrison]

Assuming that there is no reason to retain these (call me a doofus if I'm 
wrong), and that this is just unnecessary overhead, then suggest that these
be removed before 0.9.4 closes.

Comment 2

[Joe Hewitt (gone)]

fixed

Comment 3

[John Morrison]

verified gone (modulo some instances in security tree which I filed bug 112517
to cover those).