961560 - Create/use a SUMO topic redirect for the missing plugin URL

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Reuben Morais [:reuben]]

The missing plugin error message links to a 404 page in SUMO:

https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PluginHelper.js#268

This was caused because bug 702319 changed app.support.baseURL to use SUMO topic redirects like desktop does, but didn't update its users.

Comment 1

[Reuben Morais [:reuben]]

Attachment: Use a SUMO redirect in the Learn More link

Ricky, can you create the mobile-flash-unsupported redirect, pointing to https://support.mozilla.org/kb/why-cant-firefox-mobile-play-flash-on-my-device ?

Margaret, can you also confirm if that's the article we want to link to?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Reuben Morais [:reuben] from comment #1)
> Ricky, can you create the mobile-flash-unsupported redirect, pointing to
> https://support.mozilla.org/kb/why-cant-firefox-mobile-play-flash-on-my-
> device ?

Done!

Comment 3

[:Margaret Leibovic]

Comment on attachment 8362326 [details] [diff] [review]
Use a SUMO redirect in the Learn More link

Review of attachment 8362326 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this. I did a quick search to check for the other places we use app.support.baseURL, and the only other place we point to a specific article is for the telemetry link in bug 702319, so we shouldn't need to do any more fixes.

Comment 4

[:Margaret Leibovic]

Also, which versions of Firefox does this affect? Bug 702319 landed a long time ago. We should see if we can uplift this if it's currently affecting all versions.

Comment 5

[Reuben Morais [:reuben]]

(In reply to :Margaret Leibovic from comment #4)
> Also, which versions of Firefox does this affect? Bug 702319 landed a long
> time ago. We should see if we can uplift this if it's currently affecting
> all versions.

All of them, it seems:

https://hg.mozilla.org/releases/mozilla-release/file/29657549d158/mobile/android/app/mobile.js#l456
https://hg.mozilla.org/releases/mozilla-release/file/29657549d158/mobile/android/chrome/content/PluginHelper.js#l273

Comment 6

[:Margaret Leibovic]

Comment on attachment 8362326 [details] [diff] [review]
Use a SUMO redirect in the Learn More link

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 702319
User impact if declined: the missing plugin error message links to a 404 page in SUMO
Testing completed (on m-c, etc.): only tested locally
Risk to taking this patch (and alternatives if risky): low-risk, changes URL for an in-product SUMO link
String or IDL/UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/6bbfaa5f5775

Comment 8

[bhavana bajaj [:bajaj]]

Looks like a very low risk change, I am approving it on branches in parallel to m-c, so it can land today and get into our beta going to build soon.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1ba6be1ed240
https://hg.mozilla.org/releases/mozilla-beta/rev/3cad88283395

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6bbfaa5f5775