961655 - Gaia doesn't start if shell.html is loaded after webapps registry is ready

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

That's because webapps-registy-ready is never dispatched if shell.html loads after webapps registry.

This race is unlikely on device, as well as on b2g desktop as we start loading both at startup. But in Firefox mulet (bug 943878), shell.html and the system app aren't necessarely loaded on startup and can be loaded/reloaded later.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch

Ensure that webapps-registry-ready event is fired, even if the Webapps registry is initialized before shell.html is loaded.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8362451 [details] [diff] [review]
patch

Review of attachment 8362451 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm with the error fixed.

::: b2g/chrome/content/shell.js
@@ +671,3 @@
>    shell.sendChromeEvent({ type: 'webapps-registry-start' });
> +});
> +DOMApplicationRegistry.registryStarted.then(function () {

I think you want .registryReady.then() here

::: dom/apps/src/Webapps.jsm
@@ +248,4 @@
>    notifyAppsRegistryStart: function notifyAppsRegistryStart() {
>      Services.obs.notifyObservers(this, "webapps-registry-start", null);
> +    this._registryStarted.resolve();
> +  },

nit: add a blank line.

@@ +260,3 @@
>      Services.obs.notifyObservers(this, "webapps-registry-ready", null);
>      this._saveApps();
>    },

here too.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Address review comments

Comment 4

[Alexandre Poirot [:ochameau]]

https://tbpl.mozilla.org/?tree=Try&rev=ec174b6f359b

Comment 5

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d57f80bcfaa

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d57f80bcfaa