961702 - "Copy" context menu action doesn't copy rich content while document in design mode (or inside container that allows to edit its content)

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Oleg Zasypkin [:azasypkin]]

Follow-up from bug 947505, we need to add full "copy" support for rich content while in design mode (or inside container that allows to edit its content) as it's done for "cut" action. Currently is only text content is copied. 

Steps to reproduce the issue:

1) Open Firefox Metro;
2) Load a page with document.designMode set to true. E.g. http://www.kevinroth.com/rte/demo.htm;
3) Add rich content to it. Ex. for the link above insert "Table" component;
4) Put cursor inside the document, call context menu and select "Select All" context menu action;
5) Call context menu on the selected content and select "Copy" context menu action;
6) Try to paste content copied at the previous step;
7) Only simple text content is pasted.

Current Behavior:

- Only simple text content is copied in design mode.

Expected Behavior:

- Full selected rich content should be copied. Compare paste output for "Cut" command that works as intended.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: copy v1.diff

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8363128 [details] [diff] [review]
copy v1.diff

Review of attachment 8363128 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I tried a few different designMode/contenteditable/text input/non-editable scenarios and was able to cut/paste as expected. I've pushed this and the patch from bug 947505 to Try, see https://tbpl.mozilla.org/?tree=Try&rev=6fb7dcd0ecac 

We've had various test bugs surface there which failed to show up when testing locally. Lets re-trigger that 5+ times when its built and run, and call it good if its green

Comment 3

[Oleg Zasypkin [:azasypkin]]

Thanks for review! All test passed on Try, so let's move patch forward.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/3ea5b5cc5817

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ea5b5cc5817

Comment 6

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on latest Nightly (build ID: 20140226030202) and latest Aurora (build ID: 20140226004001) using a Surface Pro 2 device with the STR from the description.