961715 - Implement D3D9SurfaceImage::GetAsSourceSurface

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ali Ak]

Implement D3D9SurfaceImage::GetAsSourceSurface to do what D3D9SurfaceImage::DeprecatedGetAsSurface does for a SourceSurface

Comment 1

[Ali Ak]

Attachment: Implement D3D9SurfaceImage::GetAsSourceSurface

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8365916 [details] [diff] [review]
Implement D3D9SurfaceImage::GetAsSourceSurface

Review of attachment 8365916 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/D3D9SurfaceImage.cpp
@@ +188,5 @@
> +  // Ensure that the texture is ready to be used.
> +  EnsureSynchronized();
> +
> +  // Readback the texture from GPU memory into system memory, so that
> +  // we can copy it into the Cairo image. This is expensive.

Man, I hope we don't hit this code path (and its deprecated version) often!

Comment 3

[Ali Ak]

Attachment: Implement D3D9SurfaceImage::GetAsSourceSurface. r=nical.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6589f6ec3b6e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6589f6ec3b6e