Implement D3D9SurfaceImage::GetAsSourceSurface

RESOLVED FIXED in mozilla29

Status

()

Core
Graphics: Layers
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ali Ak, Assigned: Ali Ak)

Tracking

28 Branch
mozilla29
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Implement D3D9SurfaceImage::GetAsSourceSurface to do what D3D9SurfaceImage::DeprecatedGetAsSurface does for a SourceSurface
(Assignee)

Updated

4 years ago
Blocks: 960053
(Assignee)

Comment 1

4 years ago
Created attachment 8365916 [details] [diff] [review]
Implement D3D9SurfaceImage::GetAsSourceSurface
(Assignee)

Updated

4 years ago
Attachment #8365916 - Flags: review?(nical.bugzilla)
Comment on attachment 8365916 [details] [diff] [review]
Implement D3D9SurfaceImage::GetAsSourceSurface

Review of attachment 8365916 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/D3D9SurfaceImage.cpp
@@ +188,5 @@
> +  // Ensure that the texture is ready to be used.
> +  EnsureSynchronized();
> +
> +  // Readback the texture from GPU memory into system memory, so that
> +  // we can copy it into the Cairo image. This is expensive.

Man, I hope we don't hit this code path (and its deprecated version) often!
Attachment #8365916 - Flags: review?(nical.bugzilla) → review+

Updated

4 years ago
Assignee: nobody → ali
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

4 years ago
Created attachment 8366528 [details] [diff] [review]
Implement D3D9SurfaceImage::GetAsSourceSurface. r=nical.
Attachment #8365916 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6589f6ec3b6e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.