961740 - Highlighter outline not always visible

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

STR:

- Open http://www.mozilla.org/en-US/
- Inspect the phrase "Doing good is part of our code"
- In the markup view, make sure the actual text node is expanded
- Hover over the <p> element, the highlighter should be display correctly
- Hover over the child text node, the highlighter should be hidden
- Hover again over the <p> element

==> Only the nodeinfo bar is shown
==> Expected: both the nodeinfo bar and the outline should be shown.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: bug961740-always-show-highlighter-outline.patch

This is another small problem that appeared after bug 916443.
The change is really simple.
I added a new step in an existing test for this.
Ongoing try build: https://tbpl.mozilla.org/?tree=Try&rev=c05fe7f0f596

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 8362555 [details] [diff] [review]
bug961740-always-show-highlighter-outline.patch

Stealing review...

Comment 3

[Patrick Brosset <:pbro>]

Thanks Paul for the quick review. Try is happy too, so, I'm going to check this in.

Comment 4

[Patrick Brosset <:pbro>]

Fixed in fx-team
https://hg.mozilla.org/integration/fx-team/rev/834e7d365f01

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/834e7d365f01