961848 - Disable pointer events when doing customize mode transition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

mikedeboer mentioned this during the Paris 20140 workweek, and I think it sounds like a fine idea.

Basically, we can forgo any pointer events during the customization transition. Such events might be hover events in the menu panel - which isn't so unlikely, considering that the menu panel is usually directly under the mouse cursor during the majority of the frames of the transition.

Setting P- since the bug we're blocking is already being tracked.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: disable pointer events when doing customize mode transition

Mike, what do you think of this? If this is OK, should we switch `this._transitioning` to using the attribute throughout CustomizeMode.jsm?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8362896 [details] [diff] [review]
Patch v1: disable pointer events when doing customize mode transition

Review of attachment 8362896 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for looking at this mikedeboer! Thankfully, we've already got some attributes to indicate when we're transitioning, so we can just use those instead.

::: browser/themes/shared/customizableui/customizeMode.inc.css
@@ +2,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  /* Customization mode */
> +#main-window[customize-transitioning] #tab-view-deck {

We already have an attribute to indicate that we're transitioning (customize-entering and customize-exiting).

I think we should use those instead here:

#main-window:-moz-any([customize-entering], [customize-exiting]) #tab-view-deck {
  pointer-events: none;
}

I *think* that should do it.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: disable pointer events when doing customize mode transition

Thanks! You're right, the attributes are already there. I just took this route because it'd disable pointer events during all the shaky, janky side-effects before and after the transition. But these are just different bugs that'll get fixed in their own time, so adding just this rule is more than enough :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8363027 [details] [diff] [review]
Patch v1.1: disable pointer events when doing customize mode transition

Review of attachment 8363027 [details] [diff] [review]:
-----------------------------------------------------------------

Let's take it. Thanks mikedeboer!

Comment 5

[Mike de Boer [:mikedeboer]]

np, mconley!

Comment 6

[Mike de Boer [:mikedeboer]]

mconley, I pushed this to fx-team as https://hg.mozilla.org/integration/fx-team/rev/b5bd8c4bd163

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5bd8c4bd163