Closed Bug 961951 Opened 11 years ago Closed 11 years ago

[wifi][setting] wifi can't show network list correctly when other module is disabled

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: seinlin, Assigned: seinlin)

References

Details

Attachments

(1 file)

Do some checking before access the object
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
When bluetooth is disabled, wifi in setting will no display the network list.

        Attachment #8362813 -
        Flags: review?(arthur.chen)

    
    

    
  
Comment on attachment 8362813 [details] [review]
Do some checking before access the object

Thanks for the patch! Please check my comments in github. Also flag Alive for the system part.

        Attachment #8362813 -
        Flags: review?(arthur.chen) → review?(alive)

    
    

    
  
Arthur, Thanks! PR is updated.

        Attachment #8362813 -
        Flags: review?(alive) → review+

    
    

    
  
The patch is good. Please fix the lint error and merge with green travis.

https://travis-ci.org/mozilla-b2g/gaia/jobs/17401477
Flags: needinfo?(kli)

    
    

    
  
Done and all green. Thanks!
Flags: needinfo?(kli)

    
  
Keywords: checkin-needed

    
  
Blocks: gonk-kk

    
    

    
  
master: fdd4c4edb8e37d487f3f1ce02d72f057cb633368
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

    
  
Assignee: nobody → kli

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: