961958 - Installer fonts are blurry

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot of the installer

On a 12" Full HD screen on a laptop running windows 8.1, the installer fonts looked blurry, while the same kind of dialog in Firefox itself (for the migration wizard) look fine. It would seem like a pixel density issue, where the installer is rendering at 1:1 and scaling at 1.5:1 or something itself.

See attached screenshots. On some characters, you can even see what looks like subpixel antialiasing being itself antialiased.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Screenshot of the Firefox migration wizard, looking normal, for reference

Comment 2

[Robert Strong (they/them - no direct email)]

The stub installer is the primary installer now. Could you check if you see the same with it? If so, then this will be fixed when we have the time to convert the full installer to use the same UI. Thanks

Comment 3

[Mike Hommey [:glandium]]

The stub installer looks equally bad.

Comment 4

[Mike Hommey [:glandium]]

If that's any comfort, the bootcamp driver installer has the same problem (I guess it's just using NSIS)

Comment 5

[Robert Strong (they/them - no direct email)]

I hadn't noticed it being blurry previously and I'll check on my system after I get it back tomorrow. Thanks for the on Mac OS X data point.

Brian, have you noticed this on any of your devices?

Comment 6

[Mike Hommey [:glandium]]

Note that's *not* on a mac (I was installing bootcamp drivers to be able to use the usb dvd drive from a mac)

Comment 7

[Robert Strong (they/them - no direct email)]

Thanks. By chance were you installing on a VM or anything else somewhat unusual?

Comment 8

[Mike Hommey [:glandium]]

No, windows 8.1 straight out of the box.

Comment 9

[Mike Hommey [:glandium]]

FWIW, the MozillaBuild installer, also using NSIS, has the same problem.

Comment 10

[Robert Strong (they/them - no direct email)]

Note: NSIS added ManifestDPIAware in 3.0 Alpha 0 which should fix this with additional work.

Comment 11

[Robert Strong (they/them - no direct email)]

Attachment: Screenshot with and without ManifestDPIAware

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: Screenshot with and without SetProcessDPIAware

Comment 13

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

This fixes this bug until such a time as we can upgrade NSIS which can include <dpiAware>true</dpiAware> in the manifest.

Comment 14

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/376538c22d1f

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/376538c22d1f

Comment 16

[Catalin Varga [QA][:VarCat]]

We are lacking the proper device to reproduce the bug.
Without reproducing the bug we can't verify it.
Mike Hommey can you help us by checking to see if the bug is fixed on the latest beta ? ( http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/29.0b7-candidates/build1/win32/en-US/ )

Comment 17

[Mike Hommey [:glandium]]

The bug is indeed fixed. There are a few remaining issues, though. I'll file new bugs.

Comment 18

[Catalin Varga [QA][:VarCat]]

Thanks Mike for the provided help, marking the bug as verified.