962077 - netwerk/cache2/CacheFile.cpp:920:12: warning: ‘rv’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Nathan Froyd [:froydnj]]

Unlike a lot of other maybe-uninitialized warnings, this looks like a honest-to-goodness bug:

  nsresult rv;

  if (mMemoryOnly) {
    // TODO what exactly to do here?
    return NS_ERROR_NOT_AVAILABLE;
  }

  nsCOMPtr<CacheFileIOListener> listener;
  if (aCallback || !mHandle) {
    listener = new DoomFileHelper(aCallback);
  }
  if (mHandle) {
    rv = CacheFileIOManager::DoomFile(mHandle, listener);
  } else if (mOpeningFile) {
    mDoomAfterOpenListener = listener;
  }

  return rv;

Notice that rv is never set in the !mHandle cases.

Comment 1

[Honza Bambas (:mayhemer)]

This could be causing some intermittent timeouts we see on try runs/gum.  Thanks!

Michal, want to fix this?  I think init to NS_OK is sufficient here (and move bellow if (mMemoryOnly) {}).

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

I took the liberty.  Hope you don't work on the patch right now :)

Comment 3

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/mozilla-central/rev/0a32c3d9f7c2