962080 - js/src/jit/IonBuilder.cpp:4105:9: warning: ‘inlineable’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nathan Froyd [:froydnj] [away until 28 October]]

Patch coming in a moment.

Comment 1

[Nathan Froyd [:froydnj] [away until 28 October]]

Attachment: fix maybe-uninitialized variable warning in IonBuilder.cpp

Good practice to always provide default cases for switches anyway.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8362966 [details] [diff] [review]
fix maybe-uninitialized variable warning in IonBuilder.cpp

Review of attachment 8362966 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonBuilder.cpp
@@ +4098,5 @@
>              inlineable = true;
>              break;
> +          case InliningDecision_Error:
> +          default:
> +            return false;

Can you instead add a MOZ_ASSUME_UNREACHABLE? If somebody adds a new enum value, we should fail somehow if he/she forgets to handle it here instead of silently treating it as OOM.

Comment 3

[Nathan Froyd [:froydnj] [away until 28 October]]

Attachment: fix maybe-uninitialized variable warning in IonBuilder.cpp

Now with less code rearrangement and more MOZ_ASSUME_UNREACHABLE.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8363695 [details] [diff] [review]
fix maybe-uninitialized variable warning in IonBuilder.cpp

Review of attachment 8363695 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!

Comment 5

[Nathan Froyd [:froydnj] [away until 28 October]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7841bd2c75

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b7841bd2c75