Closed Bug 962248 Opened 11 years ago Closed 7 years ago

Intermittent browser_934951_zoom_in_toolbar.js | Uncaught exception - Condition timed out: (function () {

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: RyanVM, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [Australis:P-][stockwell fixed:other])

Attachments

(1 file)

Bug 962248 - rewrite zoom test to be less terrible,
59 bytes, text/x-review-board-request
alexical
: review+
Details
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345900&tree=Mozilla-Inbound Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound opt test mochitest-browser-chrome on 2014-01-21 11:19:00 PST for push 01d5e4bec3b4 slave: talos-mtnlion-r5-085 11:27:46 INFO - TEST-START | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js 11:27:46 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Entering test 11:27:46 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Default zoom is 100% for about:mozilla 11:27:46 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Zoom is changed to 110% for about:mozilla 11:27:46 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Default zoom is 100% for about:newtab 11:27:47 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Default zoom is 100% for about:mozilla 11:27:47 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Zoom is changed to 110% for about:mozilla 11:27:47 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Wait for tab event: load 11:27:47 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Tab event received: load 11:27:47 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Default zoom is 100% for about:home 11:27:52 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Uncaught exception - Condition timed out: (function () { 11:27:52 INFO - "use strict"; 11:27:52 INFO - return parseInt(zoomResetButton.label, 10) == 110; 11:27:52 INFO - }) 11:27:52 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Leaving test 11:27:52 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Cleaning up. 11:27:52 INFO - TEST-INFO | MEMORY STAT vsize after test: 4230291456 11:27:52 INFO - TEST-INFO | MEMORY STAT residentFast after test: 547819520 11:27:52 INFO - TEST-INFO | MEMORY STAT heapAllocated after test: 144919600 11:27:52 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | finished in 5489ms
Assignee: nobody → mdeboer
Whiteboard: [Australis:P1]
Status: NEW → ASSIGNED
Mike, bugs need to be in the dependency tree to show up on the dashboard and bug counts.
Blocks: australis-cust
Whiteboard: [Australis:P1] → [Australis:P4]
Whiteboard: [Australis:P4] → [Australis:P-]
Not actively working on this. I'll try to take look at this when I have some cycles free from loop.
Status: ASSIGNED → NEW
Assignee: mdeboer → nobody
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
In the last 7 days there are 31 failures. They occur on windows10-64 (debug, pgo), Windows 7 (debug), windows10-64-ccov (debug). Recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=177597825&lineNumber=7959 03:20:36 INFO - 344 INFO TEST-PASS | browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Default zoom is 100% for about:home - 03:20:36 INFO - Buffered messages finished 03:20:36 ERROR - 345 INFO TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | Uncaught exception - Condition timed out: (function() { 03:20:36 INFO - return parseInt(zoomResetButton.label, 10) == 110; 03:20:36 INFO - }) 03:20:36 INFO - 346 INFO Leaving test bound 03:20:36 INFO - 347 INFO Cleaning up.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Eliza Balazs [:ebalazs_] from comment #79) > In the last 7 days there are 31 failures. > They occur on windows10-64 (debug, pgo), Windows 7 (debug), > windows10-64-ccov (debug). > Recent failure log: > https://treeherder.mozilla.org/logviewer.html#?repo=mozilla- > inbound&job_id=177597825&lineNumber=7959 > 03:20:36 INFO - 344 INFO TEST-PASS | > browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | > Default zoom is 100% for about:home - > 03:20:36 INFO - Buffered messages finished > 03:20:36 ERROR - 345 INFO TEST-UNEXPECTED-FAIL | > browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js | > Uncaught exception - Condition timed out: (function() { > 03:20:36 INFO - return parseInt(zoomResetButton.label, 10) == 110; > 03:20:36 INFO - }) > 03:20:36 INFO - 346 INFO Leaving test bound > 03:20:36 INFO - 347 INFO Cleaning up. Ugh. This test is awful. I'll just rewrite bits of it and hope it goes away.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: leave-open
OS: Mac OS X → All
Hardware: x86_64 → All
Comment on attachment 8974291 [details] Bug 962248 - rewrite zoom test to be less terrible, https://reviewboard.mozilla.org/r/242600/#review248468 ::: browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js:8 (Diff revision 1) > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > /* eslint-disable mozilla/no-arbitrary-setTimeout */ > > "use strict"; > > const kTimeoutInMS = 20000; Self-nit: can remove this.
Comment on attachment 8974291 [details] Bug 962248 - rewrite zoom test to be less terrible, https://reviewboard.mozilla.org/r/242600/#review248588 The changes look good. I don't quite see how this will directly resolve the error, but it's worth cleaning up. ::: browser/components/customizableui/test/head.js (Diff revision 2) > -function promiseTabHistoryNavigation(aDirection = -1, aConditionFn) { > - return new Promise((resolve, reject) => { > - > - let timeoutId = setTimeout(() => { > - gBrowser.removeEventListener("pageshow", listener, true); > - reject("Pageshow did not happen within " + kTabEventFailureTimeoutInMs + "ms"); Nit: looks like you can remove kTabEventFailureTimeoutInMs.
Attachment #8974291 - Flags: review?(dothayer) → review+
(In reply to Doug Thayer [:dthayer] from comment #84) > The changes look good. I don't quite see how this will directly resolve the > error, but it's worth cleaning up. I think some of the promise work around history navigation etc. is a bit dodgy, especially now that some of the content pref service (so full zoom code) operations are more async than they were before. So waiting for the UI to update seems better.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1fb6a87debfa rewrite zoom test to be less terrible, r=dthayer
This looks to be gone.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Orangerobot not super helpful here - no failures since the fix landed.
Whiteboard: [Australis:P-][stockwell needswork:owner] → [Australis:P-]
https://hg.mozilla.org/releases/mozilla-esr60/rev/1496652b66f9
status-firefox-esr60: affected → fixed
Whiteboard: [Australis:P-] → [Australis:P-][stockwell fixed:other]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: