962267 - Move nsFlexContainerFrame.h's forward-decls into the class's scope

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Daniel Holbert [:dholbert]]

Mats points out in bug 783470 comment 13 that we can shift helper-class forward-decls in nsFlexContainerFrame.h into the nsFlexContainerFrame {...} class scope, and then use a typedef in the .cpp file so that we don't end up needing to be more verbose there.

Filing this bug on doing that (at least for FlexItem, FlexLine; probably most of the forward-decls at the top of nsFlexContainerFrame.h)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Note: This layers on top of the latest patches from bug 783470.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8363245 [details] [diff] [review]
fix v1

Actually, I realized that some of these don't need to be declared in the header at all anymore. New patch coming up.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

In particular: MainAxisPositionTracker and SingleLineCrossAxisPositionTracker aren't used in the .h file at all anymore (though I think they were at some point in the past), so this patch just drops their forward-decls.

Comment 4

[Daniel Holbert [:dholbert]]

Sanity-check try run (builds only): https://tbpl.mozilla.org/?tree=Try&rev=22f6253ab7f5

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81c6d8fc5702

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81c6d8fc5702