Closed Bug 962267 Opened 9 years ago Closed 9 years ago

Move nsFlexContainerFrame.h's forward-decls into the class's scope

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file, 1 obsolete file)

fix v2
4.41 KB, patch
MatsPalmgren_bugz
: review+
Details | Diff | Splinter Review 
Mats points out in bug 783470 comment 13 that we can shift helper-class forward-decls in nsFlexContainerFrame.h into the nsFlexContainerFrame {...} class scope, and then use a typedef in the .cpp file so that we don't end up needing to be more verbose there.

Filing this bug on doing that (at least for FlexItem, FlexLine; probably most of the forward-decls at the top of nsFlexContainerFrame.h)
Flags: in-testsuite-
Attached patch fix v1 (obsolete) — — Splinter Review 
Note: This layers on top of the latest patches from bug 783470.
Attachment #8363245 - Flags: review?(matspal)
Comment on attachment 8363245 [details] [diff] [review]
fix v1

Actually, I realized that some of these don't need to be declared in the header at all anymore. New patch coming up.
Attachment #8363245 - Flags: review?(matspal)
Attached patch fix v2 — — Splinter Review 
In particular: MainAxisPositionTracker and SingleLineCrossAxisPositionTracker aren't used in the .h file at all anymore (though I think they were at some point in the past), so this patch just drops their forward-decls.
Attachment #8363250 - Flags: review?(matspal)
Attachment #8363245 - Attachment is obsolete: true
Attachment #8363250 - Flags: review?(matspal) → review+
Sanity-check try run (builds only): https://tbpl.mozilla.org/?tree=Try&rev=22f6253ab7f5
https://hg.mozilla.org/mozilla-central/rev/81c6d8fc5702
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.