962313 - Disable <input type=number> for v28

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

The localization story <input type=number> for v28 is not sorted out, so I think we should disable it for v28.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8363290 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 946398
User impact if declined: real potential for <input type=number> breakage on non-English sites
Testing completed (on m-c, etc.): N/A (leaving on on m-c)
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/86e7292e66d2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing failures in tests that expected this to be enabled and don't have fallbacks for it not being so.
https://hg.mozilla.org/releases/mozilla-aurora/rev/27713189accc

https://tbpl.mozilla.org/php/getParsedLog.php?id=33631985&tree=Mozilla-Aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=33630132&tree=Mozilla-Aurora

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Are we going to get a patch for this soon? It's uplift day.

Comment 6

[Jonathan Watt [:jwatt]]

Actually, I think it would be better to wait until after v23 goes to b1. We could do with the extra exposure for at least one round of beta so that we have a better chance of fixing any issues in v29 before it too goes to beta (at which point it would most likely be to late and we'd end up knocking the release back to v30).

Comment 7

[Florian Bender]

Lukas, you relnote'd input[type=number] in Bug 930277 for 28+ while this bug aims to disable it for 28. This is a heads-up ping.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

This is currently enabled in 28 though, correct?   Johnathan what's the plan for getting this disabled wrt the tests that broke in comment 4?

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Also, 29 is on Aurora now but you mention shipping this in 30 so should we mark affected on 29 too?

Comment 10

[Jonathan Watt [:jwatt]]

The intention is for this to release in v29. When I mentioned v30 what I meant to say was that I thought keeping the pref on in v28 until the first beta of v28 is released would help us find issues sooner, reducing the chances of having to put release back to v30 because if we find issues earlier we have a better chance of fixing them on aurora (in v29).

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8363290 [details] [diff] [review]
patch

[Triage Comment]
This needs to be disabled in 28 now that we've merged, moving the approval to beta branch.

Comment 12

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f5b33434978

I also disabled the number Marionette test so it doesn't fail.

Comment 13

[Jonathan Watt [:jwatt]]

Backed out for landing on relbranch instead of default:

https://hg.mozilla.org/releases/mozilla-beta/rev/bb19d6aea785

Relanded on default:

https://hg.mozilla.org/releases/mozilla-beta/rev/5251d57dc768

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/5251d57dc768

Comment 15

[(no longer active)]

This patch did not remove the pref in b2g/app/b2g.js and mobile/android/app/mobile.js.  Is that expected?

Comment 16

[Jonathan Watt [:jwatt]]

Yes, the pref is staying on there.

Comment 17

[Petruta Horea [:phorea], Desktop QA]

Verified several pages that use input type="number" under Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OSX 10.8.5 using Firefox 28 beta 4 (20140218122424) - the feature is disabled. 
(I've checked first that it was enabled on Firefox 28 beta 1.)

Comment 18

[Jean-Yves Perrier [:teoli]]

Just so I understand correctly: currently <input type="number"> is disabled on Firefox 28 and earlier (on desktop) but is enabled in Firefox 29 Desktop (currently in Aurora) and in Firefox 30 Desktop (currently in Nightly). (And it is planned to ride the train with these versions?)

Is this correct?

(In the future could you please add dev-doc-needed on such bugs? If already written, like here, we need to update "Fx XY for developers". Thank you!)

Comment 19

[Jonathan Watt [:jwatt]]

Correct. And will do, sorry!