Closed
Bug 962314
Opened 11 years ago
Closed 11 years ago
Create nsIXULAppinfo.processID for obtaining Firefox PID
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: mikeperry, Assigned: Brade)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
|
3.12 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The Tor Launcher addon (which we use for Tor process management in Tor Browser) needs to know the current process ID of Firefox in a cross platform way. We created a getter for this purpose and exported it from nsIXULAppInfo.
Patch against FF24ESR is attached.
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
|
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8363285 [details] [diff] [review]
0001-Add-processID-API-to-nsXULAppInfo.patch
In theory nsIProcess already exposes a pid, but I'm not we have any way to get such a representation for a Gecko process. Seems reasonable to me, but over to Benjamin.
Attachment #8363285 -
Flags: review?(benjamin)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → brade
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8363285 [details] [diff] [review]
0001-Add-processID-API-to-nsXULAppInfo.patch
The NS_ENSURE_ARG_POINTER is silly for an outparam, please remove it. r=me with that change
Attachment #8363285 -
Flags: review?(benjamin) → review+
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [tor]
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Comment on attachment 8363285 [details] [diff] [review]
> 0001-Add-processID-API-to-nsXULAppInfo.patch
>
> The NS_ENSURE_ARG_POINTER is silly for an outparam, please remove it. r=me
> with that change
bsmedberg: Can you clarify? I prefer to keep NS_ENSURE_ARG_POINTER in case callers pass NULL (as is done in GetProcessType()). Lots of existing code has these checks.
|
|
||
Comment 4•11 years ago
|
||
Because this is an attribute in the IDL, JS callers can't pass NULL and it's a programming error for c++ callers to pass null. If somebody does this they should crash.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> Is there a reason this had to land directly on m-c?
Probably not. Should I have pushed it to mozilla-inbound instead?
|
||
Updated•11 years ago
|
Flags: needinfo?(brade)
You need to log in
before you can comment on or make changes to this bug.
Description
•