962328 - [B2G][SMS] The keyboard does not automatically appear when composing a new SMS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: NokeyboardSMS.txt

Description:
When the user taps on the "Compose New SMS" icon, the user is taken to the new message but the keyboard does not automatically pop up like it did on previous versions. 

Repro Steps:
1)  Updated Buri to Build ID: 20140121004137
2)  Tap on the "SMS" app.
3)  Tap on the "Compose New SMS" and pay attention to the screen. 

Actual:
The keyboard stays hidden and does not automatically pop up.

Expected:
The keyboard automatically pops up when the user is creating a new SMS. 

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20140121004137
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/6f7dfe36ab6c
Gaia: 47049555282a9a01fb60d1e1421b57e2810c96f5
Platform Version: 28.0a2
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/7956/
See attached: screenshot, logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: 2014-01-21-15-58-03.png

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not occur on the Buri v 1.2.0 Mozilla RIL 

Environmental Variables:
Device: Buri 1.2.0 Mozilla RIL
BuildID: 20140116004003
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 27e469d3cab0
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2-device.cfg

The keyboard automatically appears when composing a new SMS.

Comment 3

[Jason Smith [:jsmith]]

This might have been an intentional UX change.

UX - Can you comment on what the right behavior is here?

Comment 4

[Stephany Wilkes]

Flagging Ayman and Carrie on the expected interaction for keyboard here.

Comment 5

[ayman maat :maat]

(In reply to Stephany Wilkes from comment #4)
> Flagging Ayman and Carrie on the expected interaction for keyboard here.

New message composer should always be presented with keyboard open and cursor focus in the 'to field'
this is a regression nominating for 1.3?

Comment 6

[Julien Wajsberg [:julienw]]

Borja or Fernando, do you think you could have a look ? I wonder if that could come from the subject work.

Otherwise I'll have a look later in the week.

Comment 7

[Preeti Raghunath(:Preeti)]

There seems to be a workaround and hence in the interim will not block on this bug.

Comment 8

[Fernando Campo (:fcampo)]

Sorry, not me this time

Comment 9

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 10

[Steve Chung [:steveck]]

Comment on attachment 8376145 [details] [review]
Pull Request

Like Rick said on github, it would be great to have a test to verify toField is focused in message manager test 'launchComposer()' suite, thanks.

Comment 11

[Borja Salguero [:borjasalguero]]

Hi Steve,
I've added the recipients focus, and the test. The test is not in `launchComposer`, due to the focus is not called when coming from an Activity (which is calling launchComposer actually). I've added this when going to `new` panel. Could you take a look? Thanks!

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 8376145 [details] [review]
Pull Request

Borja, you need to put the review request back otherwise Steve might not see your request ;)

Comment 13

[Noemí Freire (:noemi)]

Triage: regression so blocking on it

Comment 14

[Noemí Freire (:noemi)]

Hi Steve,

This issue is now blocking v1.4, could you please help us with the review?. Many Thanks!.

Comment 15

[Steve Chung [:steveck]]

Comment on attachment 8376145 [details] [review]
Pull Request

Some nits to be fixed(comments on github) but looks fine overall!

Comment 16

[Borja Salguero [:borjasalguero]]

https://github.com/borjasalguero/gaia/commit/8f777b904d1816ca0d5e0b4cc0732ea9ca951cc3
https://github.com/mozilla-b2g/gaia/commit/b66c5f17db198ab42599265fae0abf9ef8a6e6b3

1.4+ / R+ / Merged.