Pass STACK_SIZE_PARAM_IS_A_RESERVATION to _beginthreadex in Windows cubeb backends to save address space
RESOLVED
FIXED
in mozilla30
Status
()
People
(Reporter: kinetik, Assigned: kinetik)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
8.98 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
See bug 958796 and https://github.com/kinetiknz/cubeb/issues/36 for background.
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 8363335 [details] [diff] [review] bug962346_v0.patch https://tbpl.mozilla.org/?tree=Try&rev=dbd9c0f7528d
Attachment #8363335 -
Flags: review?(paul)
|
||
Updated•5 years ago
|
Attachment #8363335 -
Flags: review?(paul) → review+
|
||
Comment 2•5 years ago
|
||
The NSPR part of bug 958796 just landed (on inbound) - it would be nice to get this in too. Just needs checkin-needed, right? By the way, this could also save real memory depending on how much stack the threads end up using, since without STACK_SIZE_PARAM_IS_A_RESERVATION, the stack size parameter forces Windows to commit at least that much RAM. It's still somewhat unclear how this works with the WoW64 stack on 64-bit Windows, but talos numbers for the NSPR change seems to show that it still helps :)
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f28aaa1b3df5
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f28aaa1b3df5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•