962346 - Pass STACK_SIZE_PARAM_IS_A_RESERVATION to _beginthreadex in Windows cubeb backends to save address space

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

See bug 958796 and https://github.com/kinetiknz/cubeb/issues/36 for background.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug962346_v0.patch

https://tbpl.mozilla.org/?tree=Try&rev=dbd9c0f7528d

Comment 2

[Emanuel Hoogeveen [:ehoogeveen]]

The NSPR part of bug 958796 just landed (on inbound) - it would be nice to get this in too. Just needs checkin-needed, right?

By the way, this could also save real memory depending on how much stack the threads end up using, since without STACK_SIZE_PARAM_IS_A_RESERVATION, the stack size parameter forces Windows to commit at least that much RAM. It's still somewhat unclear how this works with the WoW64 stack on 64-bit Windows, but talos numbers for the NSPR change seems to show that it still helps :)

Comment 3

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f28aaa1b3df5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f28aaa1b3df5