Closed Bug 962346 Opened 11 years ago Closed 11 years ago

Pass STACK_SIZE_PARAM_IS_A_RESERVATION to _beginthreadex in Windows cubeb backends to save address space

Categories

(Core :: Audio/Video, defect)

All
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

Attachment #8363335 - Flags: review?(paul) → review+
The NSPR part of bug 958796 just landed (on inbound) - it would be nice to get this in too. Just needs checkin-needed, right? By the way, this could also save real memory depending on how much stack the threads end up using, since without STACK_SIZE_PARAM_IS_A_RESERVATION, the stack size parameter forces Windows to commit at least that much RAM. It's still somewhat unclear how this works with the WoW64 stack on 64-bit Windows, but talos numbers for the NSPR change seems to show that it still helps :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: