962352 - [Sora][Message]MS prompt new message edit interface by tap home key.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)

Description

[sync-1]

Firefox 1.3   Mozilla build ID: 20140105004001
 DEFECT DESCRIPTION:
 ->MS prompt the message edit interface.
 
  REPRODUCING PROCEDURES:
 ->Enter"Messages" to create a message;
 ->Tap"Setting"icon to enter message settings list;
 ->Tap home key back to idle;
 
  EXPECTED BEHAVIOUR:
 ->Should back to idle normally.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Can reproduce this issue both on 1.3 and master build, a video of this bug can be found here:

http://www.youtube.com/watch?v=CoXmjqeSajU&feature=youtu.be

Dear Julien, mind taking a look at this one?

Comment 2

[Julien Wajsberg [:julienw]]

I think this is the expected behavior: the "home" button is escaping the current activity.

Alive, can you confirm ?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Is message settings an inline activity now?
If so, it's intentional.

We plan to keep the inline activity when back to home but not implemented yet.

Comment 4

[Julien Wajsberg [:julienw]]

Nope, this is a "window" activity, see [1].

Is it still intentional?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/manifest.webapp#L36-L42

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Bug :)

Comment 6

[Jason Smith [:jsmith]]

We need to find out if this reproduces on a 1.1 Buri build or not.

Comment 7

[Jason Smith [:jsmith]]

needinfo for comment 6

Comment 8

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

In Buri 1.1, UI flow of Message app is different from 1.3. In Buri 1.1, there is no "Setting Icon" while creating a SMS, hence cannot follow the reproduce step to reproduce this issue

Comment 9

[sync-1]

Attachment: Screenshots for this PR

Comment 10

[Jason Smith [:jsmith]]

Discussed via Vance - there's agreement now this isn't a blocker.

Comment 11

[sync-1]

Dears,
 
 Mozilla will not fixed this pr on v1.3. They have marked it as backlog.
 
 BRs,
 TIAN Min

Comment 12

[Jack Liu]

Dear Jason, 

There is a flash of home screen before it calls up SMS/MMS editing interface, that makes the behavior of home key operation unpredictable to user.

Is it ok to solve this bug in v1.4?

Comment 13

[Jason Smith [:jsmith]]

Alive is working on this, so it has a good chance of getting fixed in 1.4.

Comment 14

[Jack Liu]

Nice to hear this good news, thanks.

Comment 15

[Bruce Huang [:bhuang] (inactive)]

triage: 1.4+ considering the home button behavior is unexpected in this case

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

On it.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

The root cause is:
Settings app is launched as an window disposition activity and it does postError/postResult while it's closed by home button. We should not reopen the activity caller when the callee is not active.
One line patch coming.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16598

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8381209 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16598

r+ if this is the only way to tell whether or not callee should be launched.

We need to manually test this more to see if the behavior would be considered as a regression in other places.

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Settings -> Keyboard works
Gallery -> Email works

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/49312fb89b90eca48a8011b94a1a1a751daf32d2