962380 - [DSDS] When SIM 2 is primary outgoing call, dialing out emergency call under airplane mode will not successfully turn off airplane mode.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: time stamp: 9:41, 1/22

When SIM 2 is primary outgoing call, dialing out emergency call under airplane mode will not successfully turn off airplane mode.


* Build Number  
Fugu
Gaia      ee25b0e45649d2955f340ce4f71ad55712dd0fab
Gecko     913cf2b92845441c9578787362ddad6f2ac15df6
BuildID   20140121095108
Version   28.0a2

* Reproduce Steps
1. Set SIM 2 as primary outgoing call.
2. Enable airplane mode
3. Dial 911

* Expected Result
Call can be dailed out and airplane mode will be off.

* Actual Result
Call can be dailed out and airplane mode will NOT be off. UI is still in airplane mode. Unable to MT call to SIM1 but can call to SIM 2.

* Occurrence rate
100%

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Aknow, 

I verified this bug in fugu no mater on gaia master or v1.3. I have checked deeper and I found that if we set SIM1 as primary outgoing call (no matter by default or set by user manually), when dialing out 911, mozMobileConnections[0] & mozMobileConnections[1] would got `radiostatechange`. 

But if we set SIM2 as primary outgoing call, only mozMobileConnections[1] would receive this `radiostatechange`. 

Right now I use mozMobileConnectinos[0] to detect this change from Gecko by default (I know this will not work in DSDS structure with only SIM2 inserted, there is already a bug talking about this and I will fix this at that bug). 

Can you check why there is only SIM2 can receive this event in the scenario (I think this is the root cause, because both mozMobileConnections have to receive this event for sure) ? Thanks :)

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Offline discussed it with EJ.

Currently, we will only receive the 'radiostatechange' from the mobileconnection corresponding to the default outgoing SIM. That means only the radio of that SIM is enabled. Maybe we will have a modification for this part to enable the radio of both sim at the same time.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After asking Hsin-Yi, it seems that we can handle this part on Gaia. I'll take this bug first.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #3)
> After asking Hsin-Yi, it seems that we can handle this part on Gaia. I'll
> take this bug first.

It looks like Gaia bug cannot be fixed unless bug 963467 is fixed first?

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Yes Tim, we need Gecko's help for this bug.

Comment 6

[Sandip Kamat]

PM triage: Stays as a blocker

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

EJ,
Could we have an ETA for getting this patch landed on 1.3? 
Just mark ETA date on the whiteboard. example-> ETA:2/7

Comment 8

[Kai-Chih Hu [:khu]]

Can we get ETA to fix this bug? Thank you.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Ivan just discussed with me about this bug. Because this bug depends on Gecko's bug (bug 963467), I would set the ETA for Gaia side after asking Gecko about possible ETA. 

And also, if possible, I can provide Gaia patches here before Gecko if it is allowed. But we still need more testings to make sure they all work well. 

Thanks all.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After flashing gaia/master, Bug 946778 would influence the way we get radioState from mozMobileConnections. Check this line (http://goo.gl/K8GpK4) and your adb log, you would notice that this `undefined` function would make Gecko not able to receive `system-message-listener-ready` event and start doing radio related operations. 

There is already a bug talking about undefined getDataStores() function on bug 967414. 

Just want to note down all related problems here.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #10)
> After flashing gaia/master, Bug 946778 would influence the way we get
> radioState from mozMobileConnections. Check this line (http://goo.gl/K8GpK4)
> and your adb log, you would notice that this `undefined` function would make
> Gecko not able to receive `system-message-listener-ready` event and start
> doing radio related operations. 
> 

Just to be clear, this would cause Gecko unable to return right radioState and the reason why 1.3 can get radioState correctly is because bug 946778 is not uplifted in v1.3. While in master, we would face this problem if we want to access radioState to enable airplane mode.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on v1.3

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Anshul, 

can you help me test whether this bug would happen there ? 

If yes, can you apply two related patches (one is on master while another one is on v1.3) to test whether they can fix the problem or not ? 

Thanks !! :)

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi all, I just tested these two patches on our side in DSDS scenario. Here comes the long testing results and hope this can help Anshul and the others dig into the problems.

https://gist.github.com/EragonJ/44ebccdf47376b285957

Thanks.

Comment 16

[Preeti Raghunath(:Preeti)]

Inder,

Please have QC test

Comment 17

[Inder]

Preeti -- talked to Anshul and he or one of his team members will provide update here.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Inder from comment #17)
> Preeti -- talked to Anshul and he or one of his team members will provide
> update here.

Thanks Inder and Preeti !

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Jason, 

I noticed that its dependent bug 963467 has been marked as POVB, I dont think the estimated ETA is ok at this moment. 

Should we change the ETA or remove any flag ?


Thanks !

Comment 20

[Jason Smith [:jsmith]]

We probably should change the ETA - it needs to be reflective of when our partner will have this implemented.

Comment 21

[Ivan Tsay (:ITsay)]

Should we consider removing this blocker bug since its depending bug is POVB and does not have ETA for the implementation? Or do we just wait for QC test result and resolve it with the patch that works in QC test?

Comment 22

[Jason Smith [:jsmith]]

(In reply to Ivan Tsay (:ITsay) from comment #21)
> Should we consider removing this blocker bug since its depending bug is POVB
> and does not have ETA for the implementation? Or do we just wait for QC test
> result and resolve it with the patch that works in QC test?

We can't. The work required here is on our side (Gaia), but we need an underlying partner implementation to be able to test this. So we're blocked by our partner right now.

Comment 23

[Michael Schwartz [:m4]]

The patch is helping but the issue remains.  It might be our issue though.  I'll get back to you asap.

Comment 24

[Michael Schwartz [:m4]]

You guys changed the airplane mode API on us ;)  When we integrate then this works.

Comment 25

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Michael Schwartz [:m4] from comment #24)
> You guys changed the airplane mode API on us ;)  When we integrate then this
> works.

Hi Michael, I can't get it here. Can you tell more details about this part ? Thanks !

Comment 26

[Michael Schwartz [:m4]]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #25)

Don't worry about it; I was just whining ;)  Your change appears to work so r+ from me.

Comment 27

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Michael Schwartz [:m4] from comment #26)
> (In reply to EJ Chen [:eragonj][:小龍哥] from comment #25)
> 
> Don't worry about it; I was just whining ;)  Your change appears to work so
> r+ from me.

Thanks Michael !! It's a good news by the way.

Comment 28

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Ken, this patch seems ok at QRD based on Michael's comment 25, 

should I ni? somebody to do following tests to make sure why Fugu is not able to work ? 

Thanks !!

Comment 29

[Jason Smith [:jsmith]]

EJ - What's blocking getting the Gaia patch landed here? Trying to understand what's blocking the resolution of this bug.

Comment 30

[Ken Chang[:kenkai]]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #28)
> Hi Ken, this patch seems ok at QRD based on Michael's comment 25, 
> 
> should I ni? somebody to do following tests to make sure why Fugu is not
> able to work ? 
Sam, when will you fix Bug 963467? After fix Bug 963467, can you please also verify this patch in fugo device?

Comment 31

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Jason Smith [:jsmith] from comment #29)
> EJ - What's blocking getting the Gaia patch landed here? Trying to
> understand what's blocking the resolution of this bug.

Hi Jason, 

basically gaia patch is ready and got verified by Michael (with QRD). But we still can't verify this patch works or not on our own devices (You can check Ken's comment #30). 

I tested our own devices with this patch and made a testing report two weeks ago.(https://gist.github.com/EragonJ/44ebccdf47376b285957)


Thanks.

Comment 32

[sam.hua]

yes, it can turn off the airplane.
but there is the problem of should be fixed in Bug 974580

Comment 33

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8370578 [details] [review]
patch on v1.3

Arthur, 

I think this patch is ready to review, please help me take a look ! thanks :)

Comment 34

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8370577 [details] [review]
patch on master

Arthur, 

I think this patch is ready to review, please help me take a look ! thanks :)

Comment 35

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8370577 [details] [review]
patch on master

r=me with the nits addressed, thanks!

Comment 36

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8370578 [details] [review]
patch on v1.3

r=me with the nits addressed, thanks!

Comment 37

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8370578 [details] [review]
patch on v1.3

Hi Fabrice, this bug is v1.3 blocker and need your approval.

The reason why we need this change is because we didn't bind related event on another mozMobileConnetion to catch event from Gecko. And after testing on QRD (Michael's comment) & Fugu (Sam.hua's comment), gaia change is ok and works well for them. 

Btw, we already had related tests for this behavior and that's why there is no unit test in this patch.

Comment 38

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, patches were landed on :

Gaia/master : 4bb8b32d8f1a3a64bfac8f2da7878dc63e613ca5
Gaia/v1.3 : 9b29f80309212bd80fbdcf2882458b1ae8b30093

Comment 39

[Enpei]

Verified on fugu
Gaia      f692ee0e21ef4e25ec501d60226aa7da4b06ae60
Gecko     fcf711bbb0affff0925cb133c82073998bb46abf
BuildID   20140306041555
Version   28.0

Yet a big problem that UI will hang after dialing EC, chances 3/5. Tracked by bug 963467.