962516 - datastore.add breaks if a record with an existing id is added

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Jose Manuel Cantera]

This exception appears on the console, instead of reporting an error through the promise error function. 

E/GeckoConsole( 1817): [JavaScript Error: "aEvent.target is undefined" {file: "resource://gre/modules/DataStore.jsm" line: 39}]

Comment 1

[Andrea Marchesini [:baku]]

Attachment: add.patch

Comment 2

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=dbc3349fa506

Comment 3

[(no longer active)]

Comment on attachment 8363641 [details] [diff] [review]
add.patch

Review of attachment 8363641 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/datastore/DataStore.jsm
@@ -35,5 @@
>                                     "nsIMessageSender");
>  
>  /* Helper functions */
>  function createDOMError(aWindow, aEvent) {
> -  return new aWindow.DOMError(aEvent.target.error.name);

Oh, I see now that IndexedDBHelper.newTxn does this for us...  Sorry I didn't spot this in previous reviews.

::: dom/datastore/tests/file_duplicate.html
@@ +12,5 @@
> +  var gEvent;
> +  var gChangeId;
> +
> +  function is(a, b, msg) {
> +    alert((a === b ? 'OK' : 'KO') + ' ' + msg)

Nit: this can be:

function is(a, b, msg) {
  ok(a === b, msg);
}

Comment 4

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=f8c7358d06fa

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7095fa5eeb21

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7095fa5eeb21

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/800bcd3cc7eb