Closed Bug 962588 Opened 6 years ago Closed 6 years ago

Downloading update label with progress too long in some localizations, get cropped, should linewrap

Categories

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(firefox28 verified)

VERIFIED FIXED
Firefox 29
Tracking Status
firefox28 --- verified

People

(Reporter: aryx, Assigned: sfoster)

References

Details

(Whiteboard: [release28] [defect] p=2)

Attachments

(2 files, 1 obsolete file)

Attached image screenshot of issue
Firefox Aurora and Nightly 2014-01-21 on Windows 8.1 Pro 64 bit

After opening the About flyout and checking for updates, the German label for the download progress gets cropped (see screenshot). Please make this label wrap.
Whiteboard: [triage] [defect] p=0
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Whiteboard: [release28] [defect] p=0 → [release28] [defect] p=2
This is a very similar issue to bug 926036, I'll take this
Assignee: nobody → sfoster
Blocks: metrov1it23
No longer blocks: metrov1backlog
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Attached patch sidepanel-update-wrapping (obsolete) — Splinter Review
Finally got this figured out I think. I've been testing by using the dev tools to set the "downloads" box to be the selectedPanel on the updateDeck, and editing the content to be long enough to need to wrap. Presumably there's a way to tickle the update manager to ensure those steps are visible for QA to verify?

I've made corresponding changes in the js to ensure we assign to textContent not value. 
Along the way, making the downloadStatus a html:span fixed the whitespace issue (bug 962596)
Attachment #8366200 - Flags: review?(mbrubeck)
Comment on attachment 8366200 [details] [diff] [review]
sidepanel-update-wrapping

Review of attachment 8366200 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.xul
@@ +411,5 @@
> +            <image class="update-throbber"/>
> +            <description flex="1">
> +              &update.downloading.start;
> +              <html:span id="downloadStatus"></html:span>
> +              &update.downloading.end;

We shouldn't have whitespace between these three lines, for l10n reasons.  If you want to split them across multiple source code lines for readability, enclose the whitespace in XML comments:

                &update.downloading.start;<!--
		--><html:span id="downloadStatus"></html:span><!--
		-->&update.downloading.end;
Attachment #8366200 - Flags: review?(mbrubeck) → review+
Fixed whitespace/l10n issue per review comments. Carrying mbrubecks' r+
On fx-team: https://hg.mozilla.org/integration/fx-team/rev/d5e194216ce5
Attachment #8366200 - Attachment is obsolete: true
Attachment #8366208 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d5e194216ce5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Verified using a Surface Pro 2 device while updating from the 2014-02-05 nightly and aurora German builds.
The label for the download progress doesn't get cropped anymore.
Marking as verified.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.