962588 - Downloading update label with progress too long in some localizations, get cropped, should linewrap

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue

Firefox Aurora and Nightly 2014-01-21 on Windows 8.1 Pro 64 bit

After opening the About flyout and checking for updates, the German label for the download progress gets cropped (see screenshot). Please make this label wrap.

Comment 1

[Sam Foster [:sfoster] (he/him)]

This is a very similar issue to bug 926036, I'll take this

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: sidepanel-update-wrapping

Finally got this figured out I think. I've been testing by using the dev tools to set the "downloads" box to be the selectedPanel on the updateDeck, and editing the content to be long enough to need to wrap. Presumably there's a way to tickle the update manager to ensure those steps are visible for QA to verify?

I've made corresponding changes in the js to ensure we assign to textContent not value. 
Along the way, making the downloadStatus a html:span fixed the whitespace issue (bug 962596)

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8366200 [details] [diff] [review]
sidepanel-update-wrapping

Review of attachment 8366200 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.xul
@@ +411,5 @@
> +            <image class="update-throbber"/>
> +            <description flex="1">
> +              &update.downloading.start;
> +              <html:span id="downloadStatus"></html:span>
> +              &update.downloading.end;

We shouldn't have whitespace between these three lines, for l10n reasons.  If you want to split them across multiple source code lines for readability, enclose the whitespace in XML comments:

                &update.downloading.start;<!--
		--><html:span id="downloadStatus"></html:span><!--
		-->&update.downloading.end;

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix AboutFlyoutPanel upPanel updateDeck elements to layout and wrap contents correctly

Fixed whitespace/l10n issue per review comments. Carrying mbrubecks' r+
On fx-team: https://hg.mozilla.org/integration/fx-team/rev/d5e194216ce5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5e194216ce5

Comment 6

[Sam Foster [:sfoster] (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/efa507a8e34e

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Verified using a Surface Pro 2 device while updating from the 2014-02-05 nightly and aurora German builds.
The label for the download progress doesn't get cropped anymore.
Marking as verified.