Closed Bug 962622 Opened 10 years ago Closed 10 years ago

Firefox Accounts (Sign-Up) - The show/hide button corners are incorrect on pre-(Gingerbread, v12, 3.0) devices

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P3)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Platform:
All
Android
Type:
defect

Tracking

(firefox29 wontfix, firefox30 wontfix, firefox31 verified, fennec30+)

Status:
VERIFIED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- wontfix
firefox31 --- verified
fennec 30+ ---

People

(Reporter: cos_flaviu, Assigned: nalexander)

References

Details

(Keywords: polish, Whiteboard: [qa+][gingerbread])

Attachments

(2 files)

The file is a screen capture
25.17 KB, image/png
Details
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/453
57 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review 
Environment: 
Device: Motorola Atrix (Android 2.3.4);
Build: Nightly 29.0a1 (2014-01-22).

Steps to reproduce:
1. Go to Settings ->  -> Add account -> Firefox Account;
2. Check the Show\Hide button.

Expected result:
The show\hide button is narrow and the text does not fit properly.

Actual result:
There is some white space before and after the show\hide text.

Note:
Not reproducible on tablets or devices with android 4.x.
Please check the attached screen capture.
status-firefox29: --- → affected
Summary: The show\hide button is narrow and the text does not fit properly on gingerbread devices → Firefox Accounts (Sign-Up) - The show\hide button is narrow and the text does not fit properly on gingerbread devices
Ah yes, the corners is a gingerbread bug that I think we can work around.  I'll have to investigate the too narrow padding, I didn't anticipate that.
Blocks: 951304
Whiteboard: [qa+]
tracking-fennec: --- → ?
tracking-fennec: ? → 29+
Blocks: 963833
No longer blocks: 951304
Priority: -- → P2
Does this still occur on a February Nightly?
Keywords: qawanted
Yes it does. 

Device: HTC Desire HD
OS: Android 2.3 
Build: Nightyl 30.0a1 (02/05)
Keywords: qawanted
Keywords: polish
Whiteboard: [qa+] → [qa+][gingerbread]
status-firefox30: --- → affected
Is still an issue on 29?
Flags: needinfo?(flaviu.cos)
The bug is still reproducible on 29 beta 1.
Tested on HTC Desire S (Android 2.3.3).
Flags: needinfo?(flaviu.cos)
We don't have the time to tackle this for 29.
tracking-fennec: 29+ → 30+
status-firefox31: --- → affected
Assignee: nobody → nalexander
Priority: P2 → P3
This ticket is very similar to Bugs 975013 and 996855.  Let's use this one to tackle the incorrect corners.
Status: NEW → ASSIGNED
Hardware: ARM → All
Summary: Firefox Accounts (Sign-Up) - The show\hide button is narrow and the text does not fit properly on gingerbread devices → Firefox Accounts (Sign-Up) - The show/hide button is narrow and the text does not fit properly on Gingerbread devices
Attachment #8407227 - Flags: review?(rnewman) → review+
Summary: Firefox Accounts (Sign-Up) - The show/hide button is narrow and the text does not fit properly on Gingerbread devices → Firefox Accounts (Sign-Up) - The show/hide button corners are incorrect on pre-(Gingerbread, v12, 3.0) devices
https://hg.mozilla.org/mozilla-central/rev/3b4a911abb02
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Verified as fixed in build 31.0a1 (2014-04-18);
Device: Samsung Galaxy R (Android 2.3.4).
status-firefox31: fixed → verified
The bug is still reproducible on 30 beta 10.
As the Firefox 30 has landed I will change flags from FF29 and FF30 to wontfix.
status-firefox29: affected → wontfix
status-firefox30: affected → wontfix
Based on comment 11 I will mark the bug as verified.
Status: RESOLVED → VERIFIED
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.