962655 - Use build-time preference to enable rocketbar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

This is essentially a combination of four bugs in the Rocketbar branch, which we need to handle with a build-time preference instead.

The bugs are: 941276, 960344, 960249, 960884

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8363853 [details] [review]
Github pull request

Yuren, Vivien - this patch adds code to allow us to disable/enable rocketbar at build time. The code in this patch currently enables the preference as the assumption is that we will ship this in 1.4. 

This is mainly being used as a safety, and the specialized code in build/ can be removed as we near feature complete/branching.

If you have a bit of time I'd appreciate a review. Thanks!

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8363853 [details] [review]
Github pull request

Made some comment on github. The approach sounds good to me globally.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8363853 [details] [review]
Github pull request

Hi Vivien, addressed most of your comments. Let me know what you think.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8363853 [details] [review]
Github pull request

looks good to me if we have some comment to explain that manifest.activities.view properties in webapp-manifest.js.

we also need to have some tests for applications-data.js/webapp-manifest.js but I would like to add it on bug 956640.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8363853 [details] [review]
Github pull request

Thanks for the review. Vivien - if you have any follow-up comments, let me know and we can address them. Going to land this after a few more Rocketbar patches land today for a more polished experience.

Comment 11

[Kevin Grandon :kgrandon]

Now enabled by default, weee.

https://github.com/mozilla-b2g/gaia/commit/6b4def088138ef7d0af42767054d353be9d3bee3