Closed Bug 962668 Opened 6 years ago Closed 6 years ago

Android Sync: Track skew from token server and use it to generate better assertions

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

(Whiteboard: [qa+])

Attachments

(1 file)

We landed SkewHandler (yay!) and track skew to and from the sync endpoints, but we really need to track skew from the token server and use it to generate skewed local assertions.

That is, we want to adjust our *local* timestamp in generated assertions to match the token server's timestamp.
Status: NEW → ASSIGNED
QA Contact: nalexander
Attached file github PR
This should mostly address the token server failures we have been seeing.  As an aside, the SkewHandler API is excellent.
Attachment #8363793 - Flags: review?(rnewman)
Comment on attachment 8363793 [details] [review]
github PR

> As an aside, the SkewHandler API is excellent.

^5
Attachment #8363793 - Flags: review?(rnewman) → review+
Whiteboard: [qa?]
QA, this should reduce responses from the token server where we can't fetch a token due to invalid credentials.  It'll just be a general reduction in those types of failures.
Inverting dependency -- this uses SkewHandler.
No longer blocks: 929066
Depends on: 929066
https://hg.mozilla.org/mozilla-central/rev/2892bffd1570
Assignee: nobody → nalexander
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa+][fixed in services] → [qa+]
Target Milestone: --- → Firefox 29
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.