962668 - Android Sync: Track skew from token server and use it to generate better assertions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

We landed SkewHandler (yay!) and track skew to and from the sync endpoints, but we really need to track skew from the token server and use it to generate skewed local assertions.

That is, we want to adjust our *local* timestamp in generated assertions to match the token server's timestamp.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

This should mostly address the token server failures we have been seeing.  As an aside, the SkewHandler API is excellent.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8363793 [details] [review]
github PR

> As an aside, the SkewHandler API is excellent.

^5

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/services/services-central/rev/2892bffd1570

Comment 4

[Nick Alexander :nalexander [he/him]]

QA, this should reduce responses from the token server where we can't fetch a token due to invalid credentials.  It'll just be a general reduction in those types of failures.

Comment 5

[Richard Newman [:rnewman]]

Inverting dependency -- this uses SkewHandler.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/2892bffd1570