962747 - Hide Window.openDialog from content

Status: RESOLVED DUPLICATE of bug 789261

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think Window.openDialog is a gecko-specific thing. If so we should attempt to hide it from web content. I don't think it was ever intended to be used by the web but I can't see anything obvious that prevents it from being callable from the web. And the fact that window.openDialog tests true might affect future web standards as well as pollutes the global scope of the page.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hmmm.. Window.webidl says that openDialog is [ChromeOnly]. However |typeof window.openDialog| returns "function" even in content pages?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yeah, that's the XPIDL one you're seeing.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Ms2ger is right.  Once we finish moving Window to webidl, this will be fixed.

If we really wanted to we could try to do something with removing this from the xpidl, but then we have to make xrays work somehow....

Comment 4

[Tom S [:evilpie]]

Fixed by moving Window to WebIDL.