962775 - Don't set 'target' window for bugzilla links in slave health

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

Setting the target window makes opening multiple tabs or opening links in the same window mildly annoying.  Let's remove the target.

Comment 1

[John Hopkins (:jhopkins)]

Attachment: [hg.mozilla.org/users/coop_mozilla.com/slave_health] remove target

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8363933 [details] [diff] [review]
[hg.mozilla.org/users/coop_mozilla.com/slave_health] remove target

Review of attachment 8363933 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if anyone else should be reviewing patches for slave health yet, passing this along...

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8363933 [details] [diff] [review]
[hg.mozilla.org/users/coop_mozilla.com/slave_health] remove target

Review of attachment 8363933 [details] [diff] [review]:
-----------------------------------------------------------------

I guess I'm OK with this. I had this in there to make sure it didn't replace the current page, but I understand that may not be everyone's preferred workflow.

Comment 4

[John Hopkins (:jhopkins)]

I could live with "_blank" as the target name, which is supposed to always open a new window (not reuse the same new window):

 http://www.w3schools.com/tags/att_a_target.asp

Comment 5

[John Hopkins (:jhopkins)]

coop: which would you prefer - "_blank" or no target at all (as in the attached patch)?

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to John Hopkins (:jhopkins) from comment #5)
> coop: which would you prefer - "_blank" or no target at all (as in the
> attached patch)?

_blank is fine by me  if that works for you.

Comment 7

[John Hopkins (:jhopkins)]

Attachment: Use a target window of "_blank" for bugzilla links

Comment 8

[John Hopkins (:jhopkins)]

Comment on attachment 8364564 [details] [diff] [review]
Use a target window of "_blank" for bugzilla links

http://hg.mozilla.org/users/coop_mozilla.com/slave_health/rev/1f7325ced5ab